Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1763)

Issue 5846075: lilypond-book: Set include path for --output option (issue 2423). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Julien Rioux
Modified:
7 years, 2 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

lilypond-book: Set include path for --output option (issue 2423). Add the current working dir to the list of include paths.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Regression test added. #

Patch Set 3 : Fix Rietveld upload (properly rebased patch) #

Patch Set 4 : Add again the regression tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A input/regression/lilypond-book/include/example.ly View 1 1 chunk +4 lines, -0 lines 0 comments Download
A input/regression/lilypond-book/include/myvar.ily View 1 1 chunk +1 line, -0 lines 0 comments Download
M input/regression/lilypond-book/tex-include-file.lytex View 1 1 chunk +12 lines, -0 lines 0 comments Download
M input/regression/lilypond-book/tex-include-options.lytex View 1 1 chunk +12 lines, -0 lines 0 comments Download
A input/regression/lilypond-book/texinfo-include-file.tely View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Graham Percival
LGTM
7 years, 3 months ago (2012-03-20 18:03:58 UTC) #1
joeneeman
http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (right): http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639 scripts/lilypond-book.py:639: global_options.include_path.insert (0, inverse_relpath (original_dir, global_options.output_dir)) Wouldn't it be easier ...
7 years, 3 months ago (2012-03-21 00:39:47 UTC) #2
Julien Rioux
On Wed, Mar 21, 2012 at 1:39 AM, <joeneeman@gmail.com> wrote: > > http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py > File ...
7 years, 3 months ago (2012-03-21 13:37:47 UTC) #3
Julien Rioux
On Wed, Mar 21, 2012 at 9:37 AM, Julien Rioux <julien.rioux@gmail.com> wrote: > On Wed, ...
7 years, 3 months ago (2012-03-22 19:36:29 UTC) #4
Graham Percival
I'm seeing "old chunk mismatch" for this patch. Could you try uploading it again to ...
7 years, 3 months ago (2012-03-23 03:33:49 UTC) #5
Julien Rioux
On Fri, Mar 23, 2012 at 4:33 AM, <graham@percival-music.ca> wrote: > I'm seeing "old chunk ...
7 years, 3 months ago (2012-03-23 11:20:17 UTC) #6
Graham Percival
7 years, 2 months ago (2012-03-30 03:36:48 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b