lilypond-book: Set include path for --output option (issue 2423).

lilypond-book: Set include path for --output option (issue 2423).

Add the current working dir to the list of include paths.

[Graham Percival, 2012-03-20 18:03:58]

LGTM

[joeneeman, 2012-03-21 00:39:47]

http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py
File scripts/lilypond-book.py (right):

http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639
scripts/lilypond-book.py:639: global_options.include_path.insert (0,
inverse_relpath (original_dir, global_options.output_dir))
Wouldn't it be easier if you just added the absolute path to original_dir?

[Julien Rioux, 2012-03-21 13:37:47]

On Wed, Mar 21, 2012 at 1:39 AM,  <joeneeman@gmail.com> wrote:
>
> http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py
> File scripts/lilypond-book.py (right):
>
>
http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639
> scripts/lilypond-book.py:639: global_options.include_path.insert (0,
> inverse_relpath (original_dir, global_options.output_dir))
> Wouldn't it be easier if you just added the absolute path to
> original_dir?
>

It would be easier, but I think the proposed patch is a better
implementation. Using absolute paths makes the document less portable
and prone to errors caused by any weird characters that a user might
have in the names of parent directories. Absolute paths also didn't
play well with lilypond on Windows (see
http://code.google.com/p/lilypond/issues/detail?id=2209 ). While I
didn't test the suggested patch on Windows yet, I will do so very
soon.

Regards,
Julien

> http://codereview.appspot.com/5846075/

[Julien Rioux, 2012-03-22 19:36:29]

On Wed, Mar 21, 2012 at 9:37 AM, Julien Rioux <julien.rioux@gmail.com> wrote:
> On Wed, Mar 21, 2012 at 1:39 AM,  <joeneeman@gmail.com> wrote:
>>
>> http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py
>> File scripts/lilypond-book.py (right):
>>
>>
http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639
>> scripts/lilypond-book.py:639: global_options.include_path.insert (0,
>> inverse_relpath (original_dir, global_options.output_dir))
>> Wouldn't it be easier if you just added the absolute path to
>> original_dir?
>>
>
> It would be easier, but I think the proposed patch is a better
> implementation. Using absolute paths makes the document less portable
> and prone to errors caused by any weird characters that a user might
> have in the names of parent directories. Absolute paths also didn't
> play well with lilypond on Windows (see
> http://code.google.com/p/lilypond/issues/detail?id=2209 ). While I
> didn't test the suggested patch on Windows yet, I will do so very
> soon.
>
> Regards,
> Julien
>
>> http://codereview.appspot.com/5846075/

So after some testing, this looks good with python on windows, too.

[Graham Percival, 2012-03-23 03:33:49]

I'm seeing "old chunk mismatch" for this patch.  Could you try uploading it
again to a new rietveld issue?

[Julien Rioux, 2012-03-23 11:20:17]

On Fri, Mar 23, 2012 at 4:33 AM,  <graham@percival-music.ca> wrote:
> I'm seeing "old chunk mismatch" for this patch.  Could you try uploading
> it again to a new rietveld issue?
>
> http://codereview.appspot.com/5846075/

Fixed, it was a bad upload (no need for a new issue number).

[Graham Percival, 2012-03-30 03:36:48]

LGTM