Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2240)

Issue 580780043: New function css-color

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by git
Modified:
4 years, 8 months ago
Reviewers:
lilypond-pkx, lists
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New function css-color X11 and CSS colors are now independently accessible through #(x11-color <name>) or #(css-color <name>). Both color models are now completely case insensitive (as they should be), and spaces are simply stripped from the argument. That way all combinations of symbols/strings, CamelCased or lowercase etc. are accepted. If no color is found by the requested name a warning is issued (unfortunately that can't be an input warning).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -709 lines) Patch
A scm/color.scm View 1 chunk +738 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +1 line, -1 line 0 comments Download
D scm/x11-color.scm View 1 chunk +0 lines, -708 lines 0 comments Download

Messages

Total messages: 5
git
This is a follow-up patch to https://codereview.appspot.com/570690043/ For some reason it was uploaded as a ...
4 years, 9 months ago (2019-06-05 14:57:11 UTC) #1
lilypond-pkx
Patch counted down - please push
4 years, 9 months ago (2019-06-19 05:52:30 UTC) #2
lilypond-pkx
On 2019/06/05 14:57:11, git wrote: > This is a follow-up patch to > https://codereview.appspot.com/570690043/ > ...
4 years, 8 months ago (2019-07-09 17:43:31 UTC) #3
lilypond-pkx
This was stuck as 'please push' for weeks. I have retested the patch today and ...
4 years, 8 months ago (2019-07-14 12:21:26 UTC) #4
lists_openlilylib.org
4 years, 8 months ago (2019-07-14 14:35:55 UTC) #5
Thank you for doing so. 

The thing is (as buried in a comment somewhere), these regular reminders served
as an incentive for me not to forget that I wanted to push this only after
documenting the new feature...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b