Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1420)

Issue 570690043: New function css-color (accompanying x11-color)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by git
Modified:
4 years, 9 months ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New function css-color (accompanying x11-color) I was asked if LilyPond could support choosing colors by their CSS name, which I found a reasonable wish. This commit makes make-x11-color-handler generic and specifies a new function css-color. From this it would be easy to also add further namespaces and color lists. CSS colors are case insensitive, so this commit also provides support for this. Incidentally, a warning is now issued when the requested color is not defined (instead of *silently* falling back to black). Only warn about missing color when necessary Merge pull request #6 from rettinghaus/dev/urs/css-fonts add named colors from CSS Color Module Level 4 Rename x11-color.scm to color.scm With the previous commit adding `css-color` the file `x11-color.scm` should be rename to the generic `color.scm`. add named colors from CSS Color Module Level 4 Define function css-color (accompany x11-color) It should be possible to specify colors using the CSS names in addition to the X11 names. This commit makes `make-x11-color-handler` generic and adds a function `css-color`. What remains to be done is (of course documenting and) filling in the remaining ~140 colors.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -718 lines) Patch
A + scm/color.scm View 2 chunks +164 lines, -9 lines 1 comment Download
M scm/lily.scm View 1 chunk +1 line, -1 line 0 comments Download
D scm/x11-color.scm View 1 chunk +0 lines, -708 lines 0 comments Download

Messages

Total messages: 2
thomasmorley651
https://codereview.appspot.com/570690043/diff/564820043/scm/color.scm File scm/color.scm (right): https://codereview.appspot.com/570690043/diff/564820043/scm/color.scm#newcode678 scm/color.scm:678: (define css-color-list Is there anything new in this list ...
4 years, 9 months ago (2019-06-03 22:13:53 UTC) #1
git
4 years, 9 months ago (2019-06-05 19:32:48 UTC) #2
Please do *not* review this patch anymore, it has (for some reason that is
surely my fault) been replaced with https://codereview.appspot.com/580780043/ so
please review *that*...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b