Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(162)

Issue 577690043: Inline executable-* stepmake templates in lily/GNUmakefile (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by hanwenn
Modified:
10 hours, 11 minutes ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Inline executable-* stepmake templates in lily/GNUmakefile

Patch Set 1 #

Total comments: 6

Patch Set 2 : werner #

Patch Set 3 : LDLIBS #

Patch Set 4 : scripts directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -48 lines) Patch
M lily/GNUmakefile View 1 2 2 chunks +30 lines, -5 lines 0 comments Download
M scripts/GNUmakefile View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
D stepmake/stepmake/executable-rules.make View 1 chunk +0 lines, -14 lines 0 comments Download
D stepmake/stepmake/executable-targets.make View 1 chunk +0 lines, -21 lines 0 comments Download
D stepmake/stepmake/executable-vars.make View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7
lemzwerg
From visual checking I'm not sure whether your changes work as expected... https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile File lily/GNUmakefile ...
2 weeks, 5 days ago (2020-03-21 05:53:15 UTC) #1
hanwenn
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile File lily/GNUmakefile (right): https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15 lily/GNUmakefile:15: LOADLIBES = $(FLOWER_LIB) $(CONFIG_LIBS) On 2020/03/21 05:53:15, lemzwerg wrote: ...
2 weeks, 1 day ago (2020-03-25 07:33:26 UTC) #2
hanwenn
werner
2 weeks, 1 day ago (2020-03-25 07:35:52 UTC) #3
lemzwerg
> > What's the reason this isn't called `LOADLIBS`? > > you should ask the ...
2 weeks, 1 day ago (2020-03-25 07:41:54 UTC) #4
hanwenn
LDLIBS
1 week, 6 days ago (2020-03-27 16:15:37 UTC) #5
hanwenn
scripts directory
1 week, 6 days ago (2020-03-27 16:34:51 UTC) #6
hanwenn
10 hours, 11 minutes ago (2020-04-09 17:30:05 UTC) #7
commit 429e0e750be3b772f3e432afa22632981ea8fc1e
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Tue Mar 17 09:38:06 2020 +0100

    Inline executable-* stepmake templates in lily/GNUmakefile
    
    https://sourceforge.net/p/testlilyissues/issues/5852
    http://codereview.appspot.com/577690043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b