Code review - Issue 577690043: Inline executable-* stepmake templates in lily/GNUmakefilehttps://codereview.appspot.com/2020-04-09T17:30:05+00:00rietveld
Message from unknown
2020-03-20T17:56:42+00:00hanwennurn:md5:59e9aa241aa3c4182699c97ba370b3fa
Message from lemzwerg@googlemail.com
2020-03-21T05:53:15+00:00lemzwergurn:md5:f857f00586d5f5cfb4977ae1300db1e8
From visual checking I'm not sure whether your changes work as expected...
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile
File lily/GNUmakefile (right):
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15
lily/GNUmakefile:15: LOADLIBES = $(FLOWER_LIB) $(CONFIG_LIBS)
What's the reason this isn't called `LOADLIBS`?
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode18
lily/GNUmakefile:18: EXECUTABLES = $(notdir $(EXECUTABLE))
This is a funny name, too. AFAICS, this is just a single name, right?
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode28
lily/GNUmakefile:28: $(foreach a, $(EXECUTABLES), \
Since `EXECUTABLES` is a single name, we don't need a loop.
And what happened with `SEXECUTABLES`?
Message from hanwenn@gmail.com
2020-03-25T07:33:26+00:00hanwennurn:md5:f828bb0c119bbd087f885138182cbd71
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile
File lily/GNUmakefile (right):
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode15
lily/GNUmakefile:15: LOADLIBES = $(FLOWER_LIB) $(CONFIG_LIBS)
On 2020/03/21 05:53:15, lemzwerg wrote:
> What's the reason this isn't called `LOADLIBS`?
you should ask the GNU project.
https://cs.bazel.build/search?q=LOADLIBES+f%3Aakef&num=1350
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode18
lily/GNUmakefile:18: EXECUTABLES = $(notdir $(EXECUTABLE))
On 2020/03/21 05:53:15, lemzwerg wrote:
> This is a funny name, too. AFAICS, this is just a single name, right?
Done.
https://codereview.appspot.com/577690043/diff/581870043/lily/GNUmakefile#newcode28
lily/GNUmakefile:28: $(foreach a, $(EXECUTABLES), \
On 2020/03/21 05:53:15, lemzwerg wrote:
> Since `EXECUTABLES` is a single name, we don't need a loop.
>
> And what happened with `SEXECUTABLES`?
I removed it. I think SEXECUTABLES stands for Script Executables, which we don't have here.
Message from unknown
2020-03-25T07:35:51+00:00hanwennurn:md5:01593bc4dff212e7be879c7d677225f2
Message from hanwenn@gmail.com
2020-03-25T07:35:52+00:00hanwennurn:md5:ce96d39931edabdb0c95310a893a7535
werner
Message from lemzwerg@googlemail.com
2020-03-25T07:41:54+00:00lemzwergurn:md5:5d1880f73f92219135c49a8c48df8d8b
> > What's the reason this isn't called `LOADLIBS`?
>
> you should ask the GNU project.
Aah, indeed, thanks. Well, `LOADLIBES` is deprecated, and the new name is `LDLIBS`. So maybe use `LDLIBS`?
Message from unknown
2020-03-27T16:15:35+00:00hanwennurn:md5:141880b018d3f35d69536e91d1829437
Message from hanwenn@gmail.com
2020-03-27T16:15:37+00:00hanwennurn:md5:3fd24c743306c82be582b8d223b43af4
LDLIBS
Message from unknown
2020-03-27T16:34:48+00:00hanwennurn:md5:7cc0796f21c2bb808b28b7ba0347cb6a
Message from hanwenn@gmail.com
2020-03-27T16:34:51+00:00hanwennurn:md5:4cfe08be44e36265006e491483d72ab0
scripts directory
Message from hanwenn@gmail.com
2020-04-09T17:30:05+00:00hanwennurn:md5:b76815edf8783370b0c0a9c1d47a6686
commit 429e0e750be3b772f3e432afa22632981ea8fc1e
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date: Tue Mar 17 09:38:06 2020 +0100
Inline executable-* stepmake templates in lily/GNUmakefile
https://sourceforge.net/p/testlilyissues/issues/5852
http://codereview.appspot.com/577690043