musicxml2ly: portugues notenames and quarternotes in español

musicxml2ly: portugues notenames and quarternotes in español

Given by Torsten Hämmerle after issue 5746 ended.

[hanwenn, 2020-02-15 12:19:54]

https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#ne...
python/musicexp.py:375: "portugues": pitch_portugues,
português

[dak, 2020-02-15 12:29:01]

https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#ne...
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:19:54, hanwenn wrote:
> português

I don't think it makes sense to use anything here that doesn't match the
notename language defined in scm/define-note-names.scm .  There is not even an
alias português there.

[hanwenn, 2020-02-15 13:11:46]

https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#ne...
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:29:01, dak wrote:
> On 2020/02/15 12:19:54, hanwenn wrote:
> > português
> 
> I don't think it makes sense to use anything here that doesn't match the
> notename language defined in scm/define-note-names.scm .  There is not even an
> alias português there.

add this as a coment to the map.

[dak, 2020-02-15 14:21:55]

Mention that português does not exist as note language (yet?)

[hanwenn, 2020-02-15 16:58:45]

https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py
File python/musicexp.py (right):

https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#ne...
python/musicexp.py:364: function_dict = {
I meant something like

  # this map should be synchronized with scm/define-note-names.scm

[Be-3, 2020-02-15 17:58:24]

On 2020/02/15 16:58:45, hanwenn wrote:
> https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py
> File python/musicexp.py (right):
> 
>
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#ne...
> python/musicexp.py:364: function_dict = {
> I meant something like
> 
>   # this map should be synchronized with scm/define-note-names.scm

Hello,

I'd propose to leave it as it is for this patch.
But apart from that, I also dislike LilyPond's inconsistent language naming
conventions.

I've prepared a patch finally introducing full quarter tone support for all
languages and this also includes a complete set of fully tested MusicMXL pitch
import rules. And it's about proper language spelling introducing català and
português.

I've dropped a mail in the dev list asking for opinions about consistent
language naming conventions.
In any case, I'll wait with my patch until this one has been pushed.


All the best,
Torsten

[Be-3, 2020-02-15 18:02:29]

Pls see my comment about a patch introducing full quarter tone support for all
the languages - including a complete and consistent MusicXML import language
support.

I've asked on dev list about introducing català and português as "official"
consistent proper language names.
It's already included in the patch, but if people think it should stay as it is,
I'll remove the new names.

Thanks,
Torsten