Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 571630043: musicxml2ly: portugues notenames and quarternotes in español (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 1 day ago by dak
Modified:
1 week, 2 days ago
Reviewers:
Be-3, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

musicxml2ly: portugues notenames and quarternotes in español Given by Torsten Hämmerle after issue 5746 ended.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Mention that português does not exist as note language (yet?) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M python/musicexp.py View 1 2 chunks +9 lines, -2 lines 1 comment Download

Messages

Total messages: 7
hanwenn
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375 python/musicexp.py:375: "portugues": pitch_portugues, português
1 week, 6 days ago (2020-02-15 12:19:54 UTC) #1
dak
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375 python/musicexp.py:375: "portugues": pitch_portugues, On 2020/02/15 12:19:54, hanwenn wrote: > português ...
1 week, 6 days ago (2020-02-15 12:29:01 UTC) #2
hanwenn
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375 python/musicexp.py:375: "portugues": pitch_portugues, On 2020/02/15 12:29:01, dak wrote: > On ...
1 week, 6 days ago (2020-02-15 13:11:46 UTC) #3
dak
Mention that português does not exist as note language (yet?)
1 week, 6 days ago (2020-02-15 14:21:55 UTC) #4
hanwenn
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py File python/musicexp.py (right): https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364 python/musicexp.py:364: function_dict = { I meant something like # this ...
1 week, 6 days ago (2020-02-15 16:58:45 UTC) #5
Be-3
On 2020/02/15 16:58:45, hanwenn wrote: > https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py > File python/musicexp.py (right): > > https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364 > ...
1 week, 6 days ago (2020-02-15 17:58:24 UTC) #6
Be-3
1 week, 6 days ago (2020-02-15 18:02:29 UTC) #7
Pls see my comment about a patch introducing full quarter tone support for all
the languages - including a complete and consistent MusicXML import language
support.

I've asked on dev list about introducing català and português as "official"
consistent proper language names.
It's already included in the patch, but if people think it should stay as it is,
I'll remove the new names.

Thanks,
Torsten
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b