Code review - Issue 571630043: musicxml2ly: portugues notenames and quarternotes in españolhttps://codereview.appspot.com/2020-02-15T18:02:29+00:00rietveld
Message from unknown
2020-02-13T22:42:57+00:00dakurn:md5:b54259cfe87622e70fd6b3e70ab8e227
Message from hanwenn@gmail.com
2020-02-15T12:19:54+00:00hanwennurn:md5:f5d996c83959566cef41e1f141c91d02
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
português
Message from dak@gnu.org
2020-02-15T12:29:01+00:00dakurn:md5:dd7325468af84d6aa72067a8e37752fc
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:19:54, hanwenn wrote:
> português
I don't think it makes sense to use anything here that doesn't match the notename language defined in scm/define-note-names.scm . There is not even an alias português there.
Message from hanwenn@gmail.com
2020-02-15T13:11:46+00:00hanwennurn:md5:cdbf85032d42f04f4b5d822430b2eee7
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/567240043/python/musicexp.py#newcode375
python/musicexp.py:375: "portugues": pitch_portugues,
On 2020/02/15 12:29:01, dak wrote:
> On 2020/02/15 12:19:54, hanwenn wrote:
> > português
>
> I don't think it makes sense to use anything here that doesn't match the
> notename language defined in scm/define-note-names.scm . There is not even an
> alias português there.
add this as a coment to the map.
Message from unknown
2020-02-15T14:21:53+00:00dakurn:md5:d0e9d57377601acabdbe047e4936b7dd
Message from dak@gnu.org
2020-02-15T14:21:55+00:00dakurn:md5:954f3b9b1ec7af3c296317188cb49f0b
Mention that português does not exist as note language (yet?)
Message from hanwenn@gmail.com
2020-02-15T16:58:45+00:00hanwennurn:md5:2816a2d771c03fb3bdf854dc68f9cbfd
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364
python/musicexp.py:364: function_dict = {
I meant something like
# this map should be synchronized with scm/define-note-names.scm
Message from torsten.haemmerle@web.de
2020-02-15T17:58:24+00:00Be-3urn:md5:251fe9d9ca419458bc5147bd65f979f5
On 2020/02/15 16:58:45, hanwenn wrote:
> https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py
> File python/musicexp.py (right):
>
> https://codereview.appspot.com/571630043/diff/561450045/python/musicexp.py#newcode364
> python/musicexp.py:364: function_dict = {
> I meant something like
>
> # this map should be synchronized with scm/define-note-names.scm
Hello,
I'd propose to leave it as it is for this patch.
But apart from that, I also dislike LilyPond's inconsistent language naming conventions.
I've prepared a patch finally introducing full quarter tone support for all languages and this also includes a complete set of fully tested MusicMXL pitch import rules. And it's about proper language spelling introducing català and português.
I've dropped a mail in the dev list asking for opinions about consistent language naming conventions.
In any case, I'll wait with my patch until this one has been pushed.
All the best,
Torsten
Message from torsten.haemmerle@web.de
2020-02-15T18:02:29+00:00Be-3urn:md5:63be66d676bf9d0902b2fd393b727474
Pls see my comment about a patch introducing full quarter tone support for all the languages - including a complete and consistent MusicXML import language support.
I've asked on dev list about introducing català and português as "official" consistent proper language names.
It's already included in the patch, but if people think it should stay as it is, I'll remove the new names.
Thanks,
Torsten