Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 5673063: Set Influence option for Armature Actuator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by dfelinto
Modified:
8 years, 8 months ago
Reviewers:
benoit.bolsee, Moguri, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

option for the Armature Actuator to change the influence of a bone constraint. Also adds DampedTrackTo to the list of supported constraints in the BGE Test file: http://www.pasteall.org/blend/11715 Windows32 build: ftp://ftp.fisheries.ubc.ca/d.felinto/AAAS/blender262_patch_32.zip Patch developed as part of a project to NF-UBC Nereus Program. Development time 'sponsored' by the project. www.nereusprogram.org -edit: committed on rev. 44615

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -6 lines) Patch
doc/python_api/rst/bge.types.rst View 2 chunks +13 lines, -1 line 2 comments Download
source/blender/blenkernel/intern/sca.c View 2 chunks +3 lines, -0 lines 0 comments Download
source/blender/editors/space_logic/logic_window.c View 1 chunk +10 lines, -0 lines 0 comments Download
source/blender/makesdna/DNA_actuator_types.h View 2 chunks +5 lines, -2 lines 0 comments Download
source/blender/makesrna/intern/rna_actuator.c View 2 chunks +7 lines, -0 lines 2 comments Download
source/gameengine/Converter/BL_ArmatureActuator.h View 2 chunks +3 lines, -1 line 0 comments Download
source/gameengine/Converter/BL_ArmatureActuator.cpp View 4 chunks +8 lines, -1 line 0 comments Download
source/gameengine/Converter/BL_ArmatureConstraint.h View 1 chunk +5 lines, -0 lines 0 comments Download
source/gameengine/Converter/BL_ArmatureObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
source/gameengine/Converter/KX_ConvertActuators.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
dfelinto
8 years, 8 months ago (2012-02-16 02:35:57 UTC) #1
Moguri
On 2012/02/16 02:35:57, dfelinto wrote: So, is there no Python interface for adjusting bone constraints? ...
8 years, 8 months ago (2012-02-26 03:19:52 UTC) #2
Moguri
https://codereview.appspot.com/5673063/diff/1/doc/python_api/rst/bge.types.rst File doc/python_api/rst/bge.types.rst (right): https://codereview.appspot.com/5673063/diff/1/doc/python_api/rst/bge.types.rst#newcode4521 doc/python_api/rst/bge.types.rst:4521: Change weight of (only for IK) constraint. I don't ...
8 years, 8 months ago (2012-02-26 03:20:04 UTC) #3
dfelinto
8 years, 8 months ago (2012-03-03 02:45:38 UTC) #4
committing the patch. thanks for the review.
I agree that would be nice to have a python only interface, but my first concern
was to make the Armature Actuator more usable.

https://codereview.appspot.com/5673063/diff/1/doc/python_api/rst/bge.types.rst
File doc/python_api/rst/bge.types.rst (right):

https://codereview.appspot.com/5673063/diff/1/doc/python_api/rst/bge.types.rs...
doc/python_api/rst/bge.types.rst:4521: Change weight of (only for IK)
constraint.
Yeah I know but c'est la vie.
Using your suggestion now

On 2012/02/26 03:20:04, Moguri wrote:
> I don't think this doc change is directly related to the patch, but I guess
> there is no harm in slipping it in here. Although, maybe the line should be
> reworded to "Change weight of constraint (IK only)." ?

https://codereview.appspot.com/5673063/diff/1/source/blender/makesrna/intern/...
File source/blender/makesrna/intern/rna_actuator.c (right):

https://codereview.appspot.com/5673063/diff/1/source/blender/makesrna/intern/...
source/blender/makesrna/intern/rna_actuator.c:1930:
RNA_def_property_update(prop, NC_LOGIC, NULL);
not really. this is one of those .diff things. the rna prop update is for the
new property.
This function is required to call the notifier of logic space when updating this
rna function.

On 2012/02/26 03:20:04, Moguri wrote:
> It again looks like you're sneaking in extra changes. Is the property update
> actually needed (I'm not sure what it actually does)?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b