Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1646)

Issue 5626052: Gets vertical skylines from grob stencils (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by MikeSol
Modified:
6 years, 7 months ago
Reviewers:
mike, janek, wl, mike7, Neil Puttock, reinhold, mail, Graham Percival, joeneeman, dak, Keith, t.daniels, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Gets vertical skylines from grob stencils

Patch Set 1 #

Patch Set 2 : Simplifies glyph-string by adding field #

Patch Set 3 : Adds support for KeySignature #

Patch Set 4 : Better skylines for clefs #

Patch Set 5 : Provides functionality for DynamicLineSpanner #

Patch Set 6 : Better Pango support #

Patch Set 7 : Adds circle support #

Patch Set 8 : Adds nul skyline pair for elements without vertical skyline #

Patch Set 9 : Adds support for path stencils. #

Patch Set 10 : Adds polygon support #

Patch Set 11 : Adds vertical skylines to more grobs #

Patch Set 12 : Nixes Y-offset lookup for skylines #

Patch Set 13 : Representation of dev/skylines-cached #

Patch Set 14 : Fixes makefile to point to correct file #

Total comments: 15

Patch Set 15 : Fixes polygon stencil #

Patch Set 16 : Uses reverse iterator for Skyline::right #

Patch Set 17 : Gets rid of Translate_scale_rotate #

Patch Set 18 : Halves number of boxes used. #

Patch Set 19 : Gets rid of make error. #

Patch Set 20 : Caches certain grobs' vertical-skylines #

Patch Set 21 : Writes special cache functions to speed up code #

Patch Set 22 : First attempt at implementing Skylines that accept buildings directly. #

Total comments: 4

Patch Set 23 : Gets compilation times down to something reasonable #

Patch Set 24 : Avoids merges via a skyline constructor that accepts buildings #

Total comments: 2

Patch Set 25 : Fixes BassFigure #

Total comments: 2

Patch Set 26 : Fixes tuplet offset problem #

Patch Set 27 : BROKEN - doesn't play nice with certain fonts #

Patch Set 28 : Uses boxes for difficult glyphs #

Patch Set 29 : Fixes from Janek concerning lyrics and dynamics. #

Patch Set 30 : Cleaner implementation of outside-staff-horizontal-padding #

Patch Set 31 : Uses coarser quanting to speed up skyline calculations. #

Patch Set 32 : Removes call to reverse in non_overlapping_skyline functions #

Patch Set 33 : Speeds up skyline code and removes kludgy transparency stuff #

Patch Set 34 : Only uses skyline constructor when necessary from padding. #

Patch Set 35 : Eliminates superfluous loops and Building::height calls #

Patch Set 36 : Siginicant speed-ups. #

Patch Set 37 : Functional horizontal skylines #

Total comments: 4

Patch Set 38 : Problems pointed out by Keith and Janek fixed. #

Patch Set 39 : Corrects padding for horizontal skylines #

Total comments: 10

Patch Set 40 : Fixes from DAK #

Total comments: 7

Patch Set 41 : Incorporates changes from David and Janek. #

Total comments: 4

Patch Set 42 : Implements better padding. #

Patch Set 43 : Uses half of padding to test for collisions before applying full compliment #

Total comments: 35

Patch Set 44 : Incorporates suggestions from Keith. #

Patch Set 45 : Reimplements multi-pass algorithm for grobs with same priority. #

Total comments: 13

Patch Set 46 : Removes horizontal skyline code from axis-group-interface.cc #

Total comments: 8

Patch Set 47 : Integrate's Joe's most recent work #

Patch Set 48 : Run astyle on c++ files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3452 lines, -526 lines) Patch
M flower/include/interval-set.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +12 lines, -12 lines 0 comments Download
M flower/include/yaffut.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 3 chunks +3 lines, -2 lines 0 comments Download
M flower/interval-set.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +90 lines, -39 lines 0 comments Download
A flower/test-interval-set.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +110 lines, -0 lines 0 comments Download
A input/regression/hairpin-clef.ly View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A input/regression/hairpin-key-signature.ly View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A input/regression/outside-staff-placement-directive.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +106 lines, -0 lines 0 comments Download
M input/regression/skiptypesetting-all-true.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +0 lines, -6 lines 0 comments Download
M input/regression/slur-dynamics.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +1 line, -1 line 0 comments Download
A input/regression/text-script-vertical-skylines.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 1 chunk +13 lines, -0 lines 0 comments Download
A input/regression/tuplet-bracket-vertical-skylines.ly View 1 chunk +12 lines, -0 lines 0 comments Download
A input/regression/tuplet-number-outside-staff-positioning.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +17 lines, -0 lines 0 comments Download
A input/regression/volta-bracket-vertical-skylines.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 1 chunk +13 lines, -0 lines 0 comments Download
M lily/accidental.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +1 line, -0 lines 0 comments Download
M lily/accidental-placement.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +3 lines, -3 lines 0 comments Download
M lily/align-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +2 lines, -2 lines 0 comments Download
M lily/axis-group-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 10 chunks +248 lines, -84 lines 0 comments Download
M lily/beam.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 3 chunks +12 lines, -6 lines 0 comments Download
M lily/bezier.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +18 lines, -0 lines 0 comments Download
M lily/clef.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +1 line, -0 lines 0 comments Download
M lily/dot-formatting-problem.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M lily/flag.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 5 chunks +28 lines, -6 lines 0 comments Download
M lily/freetype.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 2 chunks +172 lines, -0 lines 0 comments Download
A lily/global-vars.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +59 lines, -0 lines 0 comments Download
M lily/grob.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 43 44 3 chunks +7 lines, -0 lines 0 comments Download
M lily/include/axis-group-interface.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 2 chunks +6 lines, -2 lines 0 comments Download
M lily/include/beam-scoring-problem.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -1 line 0 comments Download
M lily/include/bezier.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/box.hh View 1 chunk +2 lines, -0 lines 0 comments Download
M lily/include/freetype.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +6 lines, -0 lines 0 comments Download
M lily/include/grob.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +10 lines, -1 line 0 comments Download
M lily/include/misc.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/open-type-font.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +3 lines, -1 line 0 comments Download
M lily/include/pango-font.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +6 lines, -0 lines 0 comments Download
M lily/include/skyline.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 2 chunks +28 lines, -12 lines 0 comments Download
M lily/include/skyline-pair.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +14 lines, -3 lines 0 comments Download
M lily/include/slur.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -1 line 0 comments Download
M lily/include/stencil.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/system.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +2 lines, -1 line 0 comments Download
M lily/lily-parser.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +5 lines, -3 lines 0 comments Download
M lily/line-spanner.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +1 line, -1 line 0 comments Download
M lily/main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 3 chunks +1 line, -39 lines 0 comments Download
M lily/misc.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +20 lines, -0 lines 0 comments Download
M lily/note-spacing.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -1 line 0 comments Download
M lily/open-type-font.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +20 lines, -8 lines 0 comments Download
M lily/page-breaking.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -1 line 0 comments Download
M lily/page-layout-problem.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +1 line, -1 line 0 comments Download
M lily/pango-font.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 5 chunks +79 lines, -5 lines 0 comments Download
M lily/relocate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -2 lines 0 comments Download
M lily/script-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 2 chunks +0 lines, -2 lines 0 comments Download
M lily/separation-item.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 43 44 45 46 2 chunks +14 lines, -4 lines 0 comments Download
M lily/side-position-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 9 chunks +75 lines, -16 lines 0 comments Download
M lily/skyline.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 21 chunks +483 lines, -159 lines 1 comment Download
M lily/skyline-pair.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 5 chunks +79 lines, -9 lines 0 comments Download
M lily/slur.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +4 lines, -6 lines 0 comments Download
M lily/staff-performer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1 line, -1 line 0 comments Download
A lily/stencil-integral.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 1 chunk +1121 lines, -0 lines 0 comments Download
M lily/stencil-scheme.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +1 line, -0 lines 0 comments Download
M lily/system.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 10 chunks +50 lines, -13 lines 0 comments Download
M lily/text-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +2 lines, -0 lines 0 comments Download
M lily/tie-formatting-problem.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +1 line, -2 lines 0 comments Download
M lily/tuplet-engraver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +2 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 4 chunks +23 lines, -3 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 38 chunks +49 lines, -4 lines 0 comments Download
M scm/harp-pedals.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +7 lines, -4 lines 0 comments Download
M scm/lily.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +0 lines, -1 line 0 comments Download
M scm/output-lib.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +4 lines, -0 lines 0 comments Download
M scm/output-ps.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +3 lines, -2 lines 0 comments Download
M scm/output-svg.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 6 chunks +6 lines, -6 lines 0 comments Download
M scm/stencil.scm View 1 2 3 4 5 6 7 8 9 10 1 chunk +48 lines, -48 lines 0 comments Download
A scripts/auxiliar/show_skyline_command.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +157 lines, -0 lines 0 comments Download
A scripts/auxiliar/skyline_viewer.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 1 chunk +160 lines, -0 lines 0 comments Download

Messages

Total messages: 142
MikeSol
Sorry in advance for the whitespace errors. This patch provides a generic framework for building ...
7 years, 4 months ago (2012-02-04 21:28:16 UTC) #1
MikeSol
Hey all, Could people please try this patch out on a couple real world scores ...
7 years, 4 months ago (2012-02-06 16:42:47 UTC) #2
MikeSol
Should have added before: the most recent patch set is not bug free. I'm fixing ...
7 years, 4 months ago (2012-02-06 16:59:35 UTC) #3
mail_philholmes.net
----- Original Message ----- From: <mtsolo@gmail.com> To: <mtsolo@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Monday, February 06, ...
7 years, 4 months ago (2012-02-06 17:06:16 UTC) #4
Neil Puttock
On 6 February 2012 16:59, <mtsolo@gmail.com> wrote: > Should have added before: the most recent ...
7 years, 4 months ago (2012-02-06 17:36:06 UTC) #5
mike_apollinemike.com
On Feb 6, 2012, at 6:36 PM, Neil Puttock wrote: > On 6 February 2012 ...
7 years, 4 months ago (2012-02-06 17:50:59 UTC) #6
wl_gnu.org
>> L'Isle joyeuse: >> >> master: 0m30.432s >> patched: 0m46.997s >> >> Psalm 94 (Reubke): ...
7 years, 4 months ago (2012-02-06 18:45:56 UTC) #7
Graham Percival
On Mon, Feb 06, 2012 at 07:45:47PM +0100, Werner LEMBERG wrote: > > In my ...
7 years, 4 months ago (2012-02-06 18:52:38 UTC) #8
joeneeman
Could you publicize work-in-progress patches like this as a git branch instead of a Rietveld ...
7 years, 4 months ago (2012-02-06 19:00:55 UTC) #9
mike_apollinemike.com
On Feb 6, 2012, at 8:00 PM, Joe Neeman wrote: > Could you publicize work-in-progress ...
7 years, 4 months ago (2012-02-06 19:25:34 UTC) #10
janek
On 2012/02/06 19:25:34, mike_apollinemike.com wrote: > On Feb 6, 2012, at 8:00 PM, Joe Neeman ...
7 years, 4 months ago (2012-02-06 22:23:08 UTC) #11
MikeSol
Sorry for whitespace problems. After receiving several good general comments regarding the structure of this ...
7 years, 4 months ago (2012-02-14 09:26:55 UTC) #12
janek
Mike, On Tue, Feb 14, 2012 at 10:26 AM, <mtsolo@gmail.com> wrote: > After receiving several ...
7 years, 4 months ago (2012-02-14 16:11:44 UTC) #13
mike_apollinemike.com
On Feb 14, 2012, at 4:11 PM, Janek Warchoł wrote: > Mike, > > On ...
7 years, 4 months ago (2012-02-14 18:17:33 UTC) #14
janek
On Tue, Feb 14, 2012 at 7:17 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Thanks for taking ...
7 years, 4 months ago (2012-02-14 18:46:41 UTC) #15
mike_apollinemike.com
On Feb 14, 2012, at 6:46 PM, Janek Warchoł wrote: >> find . -name "font-cache.scm" ...
7 years, 4 months ago (2012-02-15 01:06:06 UTC) #16
janek
On Wed, Feb 15, 2012 at 2:05 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Is there something ...
7 years, 4 months ago (2012-02-15 06:00:51 UTC) #17
mike_apollinemike.com
On Feb 15, 2012, at 6:00 AM, Janek Warchoł wrote: > On Wed, Feb 15, ...
7 years, 4 months ago (2012-02-15 07:07:56 UTC) #18
janek
On Wed, Feb 15, 2012 at 8:07 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Interesting. > I'm ...
7 years, 4 months ago (2012-02-15 07:25:23 UTC) #19
mike_apollinemike.com
On Feb 15, 2012, at 7:24 AM, Janek Warchoł wrote: > It's 5000 lines of ...
7 years, 4 months ago (2012-02-15 07:37:15 UTC) #20
janek
On Wed, Feb 15, 2012 at 8:37 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Feb 15, ...
7 years, 4 months ago (2012-02-15 07:49:13 UTC) #21
mike_apollinemike.com
On Feb 15, 2012, at 7:48 AM, Janek Warchoł wrote: > On Wed, Feb 15, ...
7 years, 4 months ago (2012-02-15 07:59:14 UTC) #22
janek
On Wed, Feb 15, 2012 at 8:59 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Thanks for the ...
7 years, 4 months ago (2012-02-15 08:11:07 UTC) #23
mike_apollinemike.com
On Feb 15, 2012, at 8:10 AM, Janek Warchoł wrote: > On Wed, Feb 15, ...
7 years, 4 months ago (2012-02-15 08:17:26 UTC) #24
janek
On Wed, Feb 15, 2012 at 9:17 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Many a time ...
7 years, 4 months ago (2012-02-15 09:29:46 UTC) #25
mike_apollinemike.com
On Feb 15, 2012, at 9:29 AM, Janek Warchoł wrote: > On Wed, Feb 15, ...
7 years, 4 months ago (2012-02-15 10:13:55 UTC) #26
Graham Percival
http://codereview.appspot.com/5626052/diff/23001/mf/GNUmakefile File mf/GNUmakefile (right): http://codereview.appspot.com/5626052/diff/23001/mf/GNUmakefile#newcode231 mf/GNUmakefile:231: $(LILYPOND_BINARY) --verbose $(top-src-dir)/ly/generate-font-integrals > $@ This looks good, but ...
7 years, 4 months ago (2012-02-15 10:26:17 UTC) #27
mike_apollinemike.com
On Feb 15, 2012, at 10:26 AM, graham@percival-music.ca wrote: > > http://codereview.appspot.com/5626052/diff/23001/mf/GNUmakefile > File mf/GNUmakefile ...
7 years, 4 months ago (2012-02-15 10:31:56 UTC) #28
reinhold_kainhofer.com
On 06/02/2012 18:50, mike@apollinemike.com wrote: >>> I'm fixing all of the regtest issues, but what ...
7 years, 4 months ago (2012-02-15 14:25:57 UTC) #29
joeneeman
http://codereview.appspot.com/5626052/diff/23001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/23001/lily/axis-group-interface.cc#newcode659 lily/axis-group-interface.cc:659: vector<Grob *> *riders) I don't understand why riders are ...
7 years, 4 months ago (2012-02-16 08:09:10 UTC) #30
MikeSol
http://codereview.appspot.com/5626052/diff/23001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/23001/lily/axis-group-interface.cc#newcode659 lily/axis-group-interface.cc:659: vector<Grob *> *riders) On 2012/02/16 08:09:10, joeneeman wrote: > ...
7 years, 4 months ago (2012-02-16 10:08:39 UTC) #31
joeneeman
http://codereview.appspot.com/5626052/diff/23001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/23001/lily/axis-group-interface.cc#newcode659 lily/axis-group-interface.cc:659: vector<Grob *> *riders) On 2012/02/16 10:08:39, MikeSol wrote: > ...
7 years, 4 months ago (2012-02-16 10:40:19 UTC) #32
mike_apollinemike.com
On Feb 16, 2012, at 11:40 AM, joeneeman@gmail.com wrote: > > The buildings are in ...
7 years, 4 months ago (2012-02-16 11:14:44 UTC) #33
hanwenn
2012/2/15 Janek Warchoł <janek.lilypond@gmail.com>: >> Does your mf/out/font-cache.scm have a bunch of definitions in it ...
7 years, 4 months ago (2012-02-16 12:16:16 UTC) #34
hanwenn
On Thu, Feb 16, 2012 at 8:08 AM, <mtsolo@gmail.com> wrote: >> By the way, lilypond's ...
7 years, 4 months ago (2012-02-16 12:21:45 UTC) #35
janek
On Wed, Feb 15, 2012 at 3:25 PM, Reinhold Kainhofer <reinhold@kainhofer.com> wrote: > On 06/02/2012 ...
7 years, 4 months ago (2012-02-16 12:42:17 UTC) #36
joeneeman
On Thu, Feb 16, 2012 at 3:14 AM, mike@apollinemike.com < mike@apollinemike.com> wrote: > > On ...
7 years, 4 months ago (2012-02-16 20:31:09 UTC) #37
mike_apollinemike.com
On Feb 16, 2012, at 9:31 PM, Joe Neeman wrote: > > On Thu, Feb ...
7 years, 4 months ago (2012-02-17 07:42:54 UTC) #38
mike_apollinemike.com
On Feb 16, 2012, at 1:41 PM, Janek Warchoł wrote: > On Wed, Feb 15, ...
7 years, 4 months ago (2012-02-17 07:47:23 UTC) #39
mike_apollinemike.com
On Feb 16, 2012, at 1:21 PM, Han-Wen Nienhuys wrote: > On Thu, Feb 16, ...
7 years, 4 months ago (2012-02-17 08:00:53 UTC) #40
joeneeman
On Thu, Feb 16, 2012 at 11:42 PM, mike@apollinemike.com < mike@apollinemike.com> wrote: > On Feb ...
7 years, 4 months ago (2012-02-17 08:14:33 UTC) #41
joeneeman
On Thu, Feb 16, 2012 at 11:42 PM, mike@apollinemike.com < mike@apollinemike.com> wrote: > On Feb ...
7 years, 4 months ago (2012-02-17 08:22:49 UTC) #42
mike_apollinemike.com
On Feb 17, 2012, at 9:22 AM, Joe Neeman wrote: > On Thu, Feb 16, ...
7 years, 4 months ago (2012-02-17 08:39:01 UTC) #43
reinhold_kainhofer.com
On Fr., 17. Feb. 2012 08:47:19 CET, mike@apollinemike.com <mike@apollinemike.com> wrote: > Note that this whole ...
7 years, 4 months ago (2012-02-17 10:47:04 UTC) #44
hanwenn
On Fri, Feb 17, 2012 at 6:00 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: >> This sounds wrong. ...
7 years, 4 months ago (2012-02-17 12:49:23 UTC) #45
hanwenn
On Fri, Feb 17, 2012 at 10:49 AM, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > On Fri, ...
7 years, 4 months ago (2012-02-17 12:58:11 UTC) #46
mike_apollinemike.com
I'm relaunching my call for optimization, as the times of the patch are back up ...
7 years, 4 months ago (2012-02-18 21:17:04 UTC) #47
janek
Hi, sorry, Mike - i got confused and forgotten that a patchset newer than what ...
7 years, 4 months ago (2012-02-22 08:04:26 UTC) #48
janek
On Wed, Feb 22, 2012 at 9:04 AM, <janek.lilypond@gmail.com> wrote: > tota-pulchra.ly: > master 0m8.400s ...
7 years, 4 months ago (2012-02-22 08:07:59 UTC) #49
mike_apollinemike.com
Hey all, I've uploaded a first-pass attempt at implementing the suggestion that Joe talked about ...
7 years, 4 months ago (2012-02-22 08:18:25 UTC) #50
joeneeman
http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc#newcode393 lily/skyline.cc:393: Skyline::Skyline (Building b, Real start, Axis horizon_axis, Direction sky) ...
7 years, 4 months ago (2012-02-22 09:34:43 UTC) #51
mike_apollinemike.com
Hey all, New patch set up w/ more reasonable compilation times. If you compile \relative ...
7 years, 4 months ago (2012-02-22 15:59:16 UTC) #52
janek
On Wed, Feb 22, 2012 at 4:59 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > New patch set ...
7 years, 4 months ago (2012-02-22 16:37:56 UTC) #53
mike_apollinemike.com
Sorry, please ignore the previous patch set. There's a bad typo that breaks beams. I'll ...
7 years, 4 months ago (2012-02-22 16:47:48 UTC) #54
dak
"mike@apollinemike.com" <mike@apollinemike.com> writes: > Sorry, please ignore the previous patch set. The way to indicate ...
7 years, 4 months ago (2012-02-22 17:36:24 UTC) #55
mike_apollinemike.com
Hey all, The newest patch set implements several of Joe's suggestions but takes a time ...
7 years, 4 months ago (2012-02-23 09:35:53 UTC) #56
joeneeman
On Thu, Feb 23, 2012 at 1:35 AM, mike@apollinemike.com < mike@apollinemike.com> wrote: > Hey all, ...
7 years, 4 months ago (2012-02-23 11:11:27 UTC) #57
joeneeman
http://codereview.appspot.com/5626052/diff/34001/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/34001/lily/skyline.cc#newcode362 lily/skyline.cc:362: result.push_front (Building (last_end, -infinity_f, -infinity_f, iv[LEFT] - 2 * ...
7 years, 4 months ago (2012-02-23 11:11:47 UTC) #58
MikeSol
http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc#newcode393 lily/skyline.cc:393: Skyline::Skyline (Building b, Real start, Axis horizon_axis, Direction sky) ...
7 years, 4 months ago (2012-02-23 11:13:42 UTC) #59
dak
http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc File lily/stencil-integral.cc (right): http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc#newcode932 lily/stencil-integral.cc:932: MAKE_SCHEME_CALLBACK (Grob, simple_vertical_skylines_from_possibly_transparent_stencil, 1); Why do we need this? ...
7 years, 4 months ago (2012-02-23 12:29:06 UTC) #60
MikeSol
http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc File lily/stencil-integral.cc (right): http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc#newcode932 lily/stencil-integral.cc:932: MAKE_SCHEME_CALLBACK (Grob, simple_vertical_skylines_from_possibly_transparent_stencil, 1); On 2012/02/23 12:29:06, dak wrote: ...
7 years, 4 months ago (2012-02-23 12:37:04 UTC) #61
dak
On 2012/02/23 12:37:04, MikeSol wrote: > http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc > File lily/stencil-integral.cc (right): > > http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc#newcode932 > ...
7 years, 4 months ago (2012-02-23 13:35:29 UTC) #62
MikeSol
On 2012/02/23 13:35:29, dak wrote: > On 2012/02/23 12:37:04, MikeSol wrote: > > http://codereview.appspot.com/5626052/diff/40001/lily/stencil-integral.cc > ...
7 years, 4 months ago (2012-02-23 14:09:12 UTC) #63
dak
On 2012/02/23 14:09:12, MikeSol wrote: > On 2012/02/23 13:35:29, dak wrote: > > On 2012/02/23 ...
7 years, 4 months ago (2012-02-23 14:36:50 UTC) #64
Neil Puttock
Hi Mike, I've tested the latest patch on a few real-world scores and there appears ...
7 years, 4 months ago (2012-02-23 17:22:06 UTC) #65
joeneeman
On Thu, Feb 23, 2012 at 3:13 AM, <mtsolo@gmail.com> wrote: > > http://codereview.appspot.com/**5626052/diff/30003/lily/**skyline.cc<http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc> > File ...
7 years, 4 months ago (2012-02-23 20:47:58 UTC) #66
janek
Hey Mike, On Thu, Feb 23, 2012 at 10:35 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Janek ...
7 years, 4 months ago (2012-02-23 23:07:47 UTC) #67
mike_apollinemike.com
On Feb 24, 2012, at 12:07 AM, Janek Warchoł wrote: > Hey Mike, > > ...
7 years, 4 months ago (2012-02-23 23:50:16 UTC) #68
janek
On Fri, Feb 24, 2012 at 12:50 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Feb 24, ...
7 years, 4 months ago (2012-02-26 12:09:08 UTC) #69
mike_apollinemike.com
On Feb 26, 2012, at 1:08 PM, Janek Warchoł wrote: > On Fri, Feb 24, ...
7 years, 4 months ago (2012-02-26 15:51:20 UTC) #70
dak
"mike@apollinemike.com" <mike@apollinemike.com> writes: > On Feb 26, 2012, at 1:08 PM, Janek Warchoł wrote: > ...
7 years, 4 months ago (2012-02-26 15:54:46 UTC) #71
wl_gnu.org
>>> should we rather try to "break inside Pango" to be able to create >>> ...
7 years, 4 months ago (2012-02-26 18:37:35 UTC) #72
mike_apollinemike.com
On Feb 26, 2012, at 7:37 PM, Werner LEMBERG wrote: > > AFAIK, Pango returns ...
7 years, 4 months ago (2012-02-26 19:25:53 UTC) #73
joeneeman
On Sun, Feb 26, 2012 at 11:25 AM, mike@apollinemike.com < mike@apollinemike.com> wrote: > On Feb ...
7 years, 4 months ago (2012-02-26 21:28:25 UTC) #74
janek
On Sun, Feb 26, 2012 at 8:25 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Feb 26, ...
7 years, 4 months ago (2012-02-26 22:16:34 UTC) #75
mike_apollinemike.com
Hey all, I have a new patch up that simplifies the old one a great ...
7 years, 3 months ago (2012-02-28 12:32:22 UTC) #76
mike_apollinemike.com
Hey all, I've put up a new version that doesn't issue warnings. The only problem ...
7 years, 3 months ago (2012-02-28 21:33:06 UTC) #77
janek
Hey Mike, there's a funny situation: seems that DynamicText behaves like Hairpins behaved at one ...
7 years, 3 months ago (2012-02-28 22:16:44 UTC) #78
joeneeman
On Tue, Feb 28, 2012 at 1:32 PM, mike@apollinemike.com < mike@apollinemike.com> wrote: > Hey all, ...
7 years, 3 months ago (2012-02-29 01:05:54 UTC) #79
mike_apollinemike.com
On Feb 29, 2012, at 2:05 AM, Joe Neeman wrote: > On Tue, Feb 28, ...
7 years, 3 months ago (2012-02-29 10:17:55 UTC) #80
janek
Hey Mike, I did a quick check of newest patchset (30) and the results look ...
7 years, 3 months ago (2012-03-01 00:01:25 UTC) #81
mike_apollinemike.com
On Mar 1, 2012, at 1:01 AM, Janek Warchoł wrote: > Hey Mike, > > ...
7 years, 3 months ago (2012-03-01 07:14:50 UTC) #82
janek
On Thu, Mar 1, 2012 at 8:14 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Mar 1, ...
7 years, 3 months ago (2012-03-01 07:53:01 UTC) #83
wl_gnu.org
> From what i see, the skylines are now more precise than they need to ...
7 years, 3 months ago (2012-03-01 08:09:17 UTC) #84
hanwenn
2012/3/1 Janek Warchoł <janek.lilypond@gmail.com>: > From what i see, the skylines are now more precise ...
7 years, 3 months ago (2012-03-01 10:52:00 UTC) #85
dak
Han-Wen Nienhuys <hanwenn@gmail.com> writes: > 2012/3/1 Janek Warchoł <janek.lilypond@gmail.com>: > >> From what i see, ...
7 years, 3 months ago (2012-03-01 10:57:19 UTC) #86
hanwenn
On Thu, Mar 1, 2012 at 7:57 AM, David Kastrup <dak@gnu.org> wrote: >>> From what ...
7 years, 3 months ago (2012-03-01 10:59:02 UTC) #87
mike_apollinemike.com
On Mar 1, 2012, at 11:52 AM, Han-Wen Nienhuys wrote: > 2012/3/1 Janek Warchoł <janek.lilypond@gmail.com>: ...
7 years, 3 months ago (2012-03-01 11:00:16 UTC) #88
mike_apollinemike.com
On Mar 1, 2012, at 11:59 AM, Han-Wen Nienhuys wrote: >> >> Well, it is ...
7 years, 3 months ago (2012-03-01 11:00:36 UTC) #89
t.daniels_treda.co.uk
Janek Warchoł wrote Thursday, March 01, 2012 12:01 AM > The bad news is that ...
7 years, 3 months ago (2012-03-01 11:17:31 UTC) #90
mike_apollinemike.com
On Mar 1, 2012, at 12:17 PM, Trevor Daniels wrote: > > Janek Warchoł wrote ...
7 years, 3 months ago (2012-03-01 11:28:01 UTC) #91
janek
On Thu, Mar 1, 2012 at 12:00 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Mar 1, ...
7 years, 3 months ago (2012-03-01 20:56:22 UTC) #92
janek
Mike & all, i did a quick compile with patchset 36 and unfortunately didn't notice ...
7 years, 3 months ago (2012-03-06 14:18:03 UTC) #93
joeneeman
2012/3/6 <janek.lilypond@gmail.com> > Mike & all, > > i did a quick compile with patchset ...
7 years, 3 months ago (2012-03-06 22:48:39 UTC) #94
janek
On Tue, Mar 6, 2012 at 11:48 PM, Joe Neeman <joeneeman@gmail.com> wrote: > 2012/3/6 <janek.lilypond@gmail.com> ...
7 years, 3 months ago (2012-03-07 07:56:46 UTC) #95
joeneeman
2012/3/6 Janek Warchoł <janek.lilypond@gmail.com> > On Tue, Mar 6, 2012 at 11:48 PM, Joe Neeman ...
7 years, 3 months ago (2012-03-07 10:43:31 UTC) #96
janek
On Wed, Mar 7, 2012 at 11:43 AM, Joe Neeman <joeneeman@gmail.com> wrote: > > 2012/3/6 ...
7 years, 3 months ago (2012-03-07 21:32:47 UTC) #97
joeneeman
2012/3/7 Janek Warchoł <janek.lilypond@gmail.com> > On Wed, Mar 7, 2012 at 11:43 AM, Joe Neeman ...
7 years, 3 months ago (2012-03-07 21:50:21 UTC) #98
janek
On Wed, Mar 7, 2012 at 10:50 PM, Joe Neeman <joeneeman@gmail.com> wrote: > 2012/3/7 Janek ...
7 years, 3 months ago (2012-03-07 22:09:16 UTC) #99
mike_apollinemike.com
Hey all, An update on this patch. After having correctly skylined dynamics, I'm realizing that ...
7 years, 3 months ago (2012-03-08 09:04:58 UTC) #100
MikeSol
It's back... The only thing that doesn't the work the way I'd expect it is ...
6 years, 12 months ago (2012-07-01 14:58:08 UTC) #101
Keith
I like the direction in which this goes, making things closer, because it is easier ...
6 years, 11 months ago (2012-07-01 23:03:56 UTC) #102
Keith
http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc#newcode693 lily/skyline.cc:693: Skyline::padded (Real horizon_padding) const The horizon_padding built in to ...
6 years, 11 months ago (2012-07-01 23:04:16 UTC) #103
MikeSol
http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/78001/lily/skyline.cc#newcode693 lily/skyline.cc:693: Skyline::padded (Real horizon_padding) const On 2012/07/01 23:04:17, Keith wrote: ...
6 years, 11 months ago (2012-07-02 04:58:21 UTC) #104
janek
Hi all, my favorite patch returned! Yay! I did some testing and the results are ...
6 years, 11 months ago (2012-07-03 08:19:17 UTC) #105
mike_apollinemike.com
On 2 juil. 2012, at 01:03, k-ohara5a5a@oco.net wrote: > I like the direction in which ...
6 years, 11 months ago (2012-07-03 17:51:49 UTC) #106
Keith
On Tue, 03 Jul 2012 10:51:05 -0700, mike@apollinemike.com <mike@apollinemike.com> wrote: > Could you tell me ...
6 years, 11 months ago (2012-07-04 01:18:05 UTC) #107
janek
On Mon, Jul 2, 2012 at 1:03 AM, <k-ohara5a5a@oco.net> wrote: > I did a quick ...
6 years, 11 months ago (2012-07-04 07:34:41 UTC) #108
mike_apollinemike.com
On 3 juil. 2012, at 10:18, Janek Warchoł wrote: > Hi all, > > my ...
6 years, 11 months ago (2012-07-04 10:54:21 UTC) #109
janek
On Wed, Jul 4, 2012 at 11:31 AM, mike@apollinemike.com <mike@apollinemike.com> wrote: > Thanks Janek! Very ...
6 years, 11 months ago (2012-07-04 13:17:37 UTC) #110
mike_apollinemike.com
On 4 juil. 2012, at 15:17, Janek Warchoł wrote: > On Wed, Jul 4, 2012 ...
6 years, 11 months ago (2012-07-04 13:36:15 UTC) #111
mail_philholmes.net
----- Original Message ----- From: <mike@apollinemike.com> To: "Janek Warchoł" <janek.lilypond@gmail.com> > > In short: > ...
6 years, 11 months ago (2012-07-04 13:52:14 UTC) #112
janek
On Wed, Jul 4, 2012 at 3:36 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > >> No idea ...
6 years, 11 months ago (2012-07-04 18:58:30 UTC) #113
mike_apollinemike.com
On 4 juil. 2012, at 21:58, Janek Warchoł wrote: > On Wed, Jul 4, 2012 ...
6 years, 11 months ago (2012-07-05 15:23:25 UTC) #114
janek
On Thu, Jul 5, 2012 at 5:23 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > New patch set ...
6 years, 11 months ago (2012-07-05 16:05:57 UTC) #115
dak
I actually only wanted to get rid of the whitespace errors plagueing every test of ...
6 years, 11 months ago (2012-07-09 08:42:16 UTC) #116
joeneeman
Just looked at skyline-related stuff for now... http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc#newcode292 lily/skyline.cc:292: Real p1 ...
6 years, 11 months ago (2012-07-14 14:01:08 UTC) #117
MikeSol
http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc File lily/skyline.cc (right): http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc#newcode292 lily/skyline.cc:292: Real p1 = left->end_ * left->slope_ + left->y_intercept_; On ...
6 years, 11 months ago (2012-07-14 18:33:10 UTC) #118
joeneeman
On Sat, Jul 14, 2012 at 8:33 PM, <mtsolo@gmail.com> wrote: > > http://codereview.appspot.com/**5626052/diff/85004/lily/** > skyline.cc#newcode302<http://codereview.appspot.com/5626052/diff/85004/lily/skyline.cc#newcode302> ...
6 years, 11 months ago (2012-07-15 15:30:03 UTC) #119
Keith
Worked nicely on some piano music and a Dvorak symphony. The code is bewildering. So ...
6 years, 10 months ago (2012-08-14 04:21:32 UTC) #120
MikeSol
Thanks for the review! http://codereview.appspot.com/5626052/diff/105001/input/regression/text-script-vertical-skylines.ly File input/regression/text-script-vertical-skylines.ly (right): http://codereview.appspot.com/5626052/diff/105001/input/regression/text-script-vertical-skylines.ly#newcode5 input/regression/text-script-vertical-skylines.ly:5: kerning. On 2012/08/14 04:21:33, Keith ...
6 years, 10 months ago (2012-08-16 04:15:38 UTC) #121
MikeSol
http://codereview.appspot.com/5626052/diff/105001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/105001/lily/axis-group-interface.cc#newcode778 lily/axis-group-interface.cc:778: Note we only use 75% of padding and apply ...
6 years, 10 months ago (2012-08-16 06:21:40 UTC) #122
Keith
patch real 17m55.095s user 17m10.848s sys 0m11.381s git master real 16m16.228s user 15m30.543s sys 0m10.624s ...
6 years, 10 months ago (2012-08-17 08:12:56 UTC) #123
joeneeman
http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc#newcode651 lily/axis-group-interface.cc:651: -------------------------------/ I've experimented with disabling the horizontal skylines, and ...
6 years, 10 months ago (2012-08-17 11:19:26 UTC) #124
mike7
On 17 août 2012, at 07:19, joeneeman@gmail.com wrote: > > http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc > File lily/axis-group-interface.cc (right): ...
6 years, 10 months ago (2012-08-17 14:21:21 UTC) #125
mike7
On 17 août 2012, at 10:21, "mike@mikesolomon.org" <mike@mikesolomon.org> wrote: > On 17 août 2012, at ...
6 years, 10 months ago (2012-08-17 14:28:50 UTC) #126
MikeSol
I've forgotten why I added the horizontal skyline stuff so I've taken it out in ...
6 years, 10 months ago (2012-08-17 17:16:25 UTC) #127
Keith
On Fri, 17 Aug 2012 10:16:25 -0700, <mtsolo@gmail.com> wrote: > > http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc#newcode780 > lily/axis-group-interface.cc:780: while ...
6 years, 10 months ago (2012-08-17 19:25:29 UTC) #128
joeneeman
On Sat, Aug 18, 2012 at 5:34 AM, Keith OHara <k-ohara5a5a@oco.net> wrote: > On Fri, ...
6 years, 10 months ago (2012-08-17 20:57:51 UTC) #129
mike7
On 17 août 2012, at 16:57, Joe Neeman <joeneeman@gmail.com> wrote: > > On Sat, Aug ...
6 years, 10 months ago (2012-08-17 22:50:48 UTC) #130
Keith
This is barely slower than master on an orchestral score and parts patch master real ...
6 years, 10 months ago (2012-08-18 02:42:37 UTC) #131
MikeSol
Thanks for the performance tests! I have no problem changing the function avoid_outside_staff_collisions to be ...
6 years, 10 months ago (2012-08-18 10:12:00 UTC) #132
joeneeman
On 2012/08/17 19:25:29, Keith wrote: > On Fri, 17 Aug 2012 10:16:25 -0700, <mailto:mtsolo@gmail.com> wrote: ...
6 years, 10 months ago (2012-08-21 07:22:58 UTC) #133
Keith
On 2012/08/18 10:12:00, MikeSol wrote: > Agreed. I'd love for this to go faster. The ...
6 years, 10 months ago (2012-08-21 07:32:15 UTC) #134
Keith
On 2012/08/21 07:32:15, Keith wrote: > There was, however, no measurable difference in speed on ...
6 years, 10 months ago (2012-08-21 07:34:06 UTC) #135
Keith
On 2012/08/18 10:12:00, MikeSol wrote: > \relative c'' { > \override TupletBracket #'outside-staff-priority = #1 ...
6 years, 10 months ago (2012-08-21 07:42:38 UTC) #136
mike7
On 21 août 2012, at 03:42, k-ohara5a5a@oco.net wrote: > On 2012/08/18 10:12:00, MikeSol wrote: > ...
6 years, 10 months ago (2012-08-21 09:43:51 UTC) #137
joeneeman
On 2012/08/21 07:42:38, Keith wrote: > On 2012/08/18 10:12:00, MikeSol wrote: > > > \relative ...
6 years, 10 months ago (2012-08-22 03:43:03 UTC) #138
Keith
Works nice. But so far the density of problems in the code as been pretty ...
6 years, 10 months ago (2012-08-22 04:20:20 UTC) #139
Keith
Still works well, still the same speed, and now the code makes much more sense. ...
6 years, 10 months ago (2012-08-28 04:08:11 UTC) #140
mike7
On 28 août 2012, at 06:08, k-ohara5a5a@oco.net wrote: > Still works well, still the same ...
6 years, 10 months ago (2012-08-28 08:00:49 UTC) #141
Keith
6 years, 9 months ago (2012-09-16 18:52:55 UTC) #142
http://codereview.appspot.com/5626052/diff/114002/lily/skyline.cc
File lily/skyline.cc (right):

http://codereview.appspot.com/5626052/diff/114002/lily/skyline.cc#newcode111
lily/skyline.cc:111: if (start_height != end_height)
Does anyone know the reason for this change?

For some unusual input (issue 2836)
 { \override NoteHead #'stencil = ##f b2 b  } 
both _heights can be NaNs, due to some other change in this patch.   

This re-arrangement of logic looks like it /might/ have been intended to set
slope_=0 for NaNs on input, but in fact we get slope_=NaN and are trapped at the
assertion below.  (My reading of the standard says NaN==NaN is false, NaN!=NaN
is true, so gcc seems to comply.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b