Issue 6462087: Simplifications, relative to http://codereview.appspot.com/5626052/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6462087: Simplifications, relative to http://codereview.appspot.com/5626052/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by Keith

Modified:
11 years, 1 month ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Simplifications, relative to http://codereview.appspot.com/5626052/

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -171 lines)			Patch
	M	flower/include/interval.hh	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	lily/axis-group-interface.cc	View		10 chunks	+39 lines, -171 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Keith

11 years, 8 months ago (2012-08-21 08:08:09 UTC) #1

http://codereview.appspot.com/6462087/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (left):

http://codereview.appspot.com/6462087/diff/1/lily/axis-group-interface.cc#old...
lily/axis-group-interface.cc:777: Drul_array<Real> last_affected_position;
This is worth keeping, because the tendency to alternate close and far
placements looks nicer than building a staircase, and starting again at the
closest position when there is room.

http://codereview.appspot.com/6462087/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

http://codereview.appspot.com/6462087/diff/1/lily/axis-group-interface.cc#new...
lily/axis-group-interface.cc:857: doctored_skylines[-d].set_minimum_height
(0.0);
Setting the inside boundary to 0.0 prevents tucking things under the on-staff
Grobs.  It seems wiser to just skip the 'doctored_skylines' step.

Expand All Messages | Collapse All Messages