Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2463)

Issue 557190043: lily: fix some type conversion warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 6 days ago by hanwenn
Modified:
3 days, 8 hours ago
Reviewers:
dak, dan, lemzwerg, benko.pal, Dan Eble, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

lily: fix some type conversion warnings

Patch Set 1 #

Total comments: 4

Patch Set 2 : Dan's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M lily/break-substitution.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 23
lemzwerg
From inspection only: LGTM, thanks! https://codereview.appspot.com/557190043/diff/581490044/lily/lookup.cc File lily/lookup.cc (right): https://codereview.appspot.com/557190043/diff/581490044/lily/lookup.cc#newcode314 lily/lookup.cc:314: int i0 = (int) ...
3 weeks, 6 days ago (2020-01-20 16:32:31 UTC) #1
Dan Eble
https://codereview.appspot.com/557190043/diff/581490044/lily/pointer-group-interface.cc File lily/pointer-group-interface.cc (right): https://codereview.appspot.com/557190043/diff/581490044/lily/pointer-group-interface.cc#newcode30 lily/pointer-group-interface.cc:30: return arr ? int (arr->size ()) : 0; MHO: ...
3 weeks, 5 days ago (2020-01-21 15:21:56 UTC) #2
hanwenn
On 2020/01/21 15:21:56, Dan Eble wrote: > https://codereview.appspot.com/557190043/diff/581490044/lily/pointer-group-interface.cc > File lily/pointer-group-interface.cc (right): > > https://codereview.appspot.com/557190043/diff/581490044/lily/pointer-group-interface.cc#newcode30 ...
3 weeks, 4 days ago (2020-01-22 10:15:03 UTC) #3
hanwenn
On 2020/01/22 10:15:03, hanwenn wrote: > On 2020/01/21 15:21:56, Dan Eble wrote: > > > ...
3 weeks, 4 days ago (2020-01-22 10:18:48 UTC) #4
benko.pal
On 2020/01/22 10:15:03, hanwenn wrote: > Why do we need to have the distinction between ...
3 weeks, 4 days ago (2020-01-22 11:18:17 UTC) #5
Dan Eble
On 2020/01/22 10:18:48, hanwenn wrote: > alternately, we could just do -Wno-conversion in the makefile, ...
3 weeks, 2 days ago (2020-01-23 20:02:58 UTC) #6
hanwenn
On 2020/01/23 20:02:58, Dan Eble wrote: > On 2020/01/22 10:18:48, hanwenn wrote: > > alternately, ...
3 weeks, 2 days ago (2020-01-23 20:49:01 UTC) #7
dak
hanwenn@gmail.com writes: > In LilyPond, the bulk of the warnings come from unsigned 64 bit ...
3 weeks, 2 days ago (2020-01-23 21:11:12 UTC) #8
Dan Eble
On 2020/01/23 20:49:01, hanwenn wrote: > I mean, if we were writing a new SSL ...
3 weeks, 2 days ago (2020-01-23 21:43:32 UTC) #9
hanwenn
On Thu, Jan 23, 2020 at 10:11 PM David Kastrup <dak@gnu.org> wrote: > hanwenn@gmail.com writes: ...
3 weeks, 2 days ago (2020-01-24 08:49:29 UTC) #10
dan_faithful.be
On Jan 24, 2020, at 03:49, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > > (I think Dan ...
3 weeks, 2 days ago (2020-01-24 11:29:30 UTC) #11
dan_faithful.be
On Jan 24, 2020, at 03:49, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > The alternative is that ...
3 weeks, 2 days ago (2020-01-24 12:13:42 UTC) #12
dak
Dan Eble <dan@faithful.be> writes: > On Jan 24, 2020, at 03:49, Han-Wen Nienhuys <hanwenn@gmail.com> wrote: ...
3 weeks, 2 days ago (2020-01-24 13:08:29 UTC) #13
hanwenn
There are two problems that are tangentially related, and I think the discussion comes from ...
2 weeks, 3 days ago (2020-01-30 08:37:44 UTC) #14
hahnjo
On 2020/01/30 08:37:44, hanwenn wrote: > There are two problems that are tangentially related, and ...
2 weeks, 3 days ago (2020-01-30 09:00:10 UTC) #15
lemzwerg
> I don't like this methodology, +1 > I prefer what Dan does right now ...
2 weeks, 3 days ago (2020-01-30 09:20:52 UTC) #16
hanwenn
> I don't like this methodology, what's the difference over disabling > -Wconversion My selfish ...
2 weeks ago (2020-02-02 14:15:04 UTC) #17
dan_faithful.be
On Feb 2, 2020, at 09:15, hanwenn@gmail.com wrote: > >> I don't like this methodology, ...
2 weeks ago (2020-02-02 14:41:51 UTC) #18
hanwenn
On 2020/02/02 14:41:51, dan_faithful.be wrote: > On Feb 2, 2020, at 09:15, mailto:hanwenn@gmail.com wrote: > ...
2 weeks ago (2020-02-02 15:15:53 UTC) #19
Dan Eble
The changes to lily/break-substitution.cc are exactly what I would do. What do you think about ...
1 week, 6 days ago (2020-02-03 19:41:07 UTC) #20
hanwenn
A-OK.
1 week, 5 days ago (2020-02-03 19:55:33 UTC) #21
hanwenn
Dan's suggestion
1 week, 5 days ago (2020-02-03 19:58:54 UTC) #22
hanwenn
3 days, 8 hours ago (2020-02-13 11:40:13 UTC) #23
commit 4d93339b06f97dcec176a47d9db0fc169acccef6
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Jan 17 23:42:28 2020 +0100

    lily: fix some type conversion warnings
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b