Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 563460043: Make all int -> Real casts explicit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 5 days ago by hanwenn
Modified:
2 weeks, 6 days ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make all int -> Real casts explicit

Patch Set 1 #

Patch Set 2 : static_cast #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M lily/lookup.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/mensural-ligature-engraver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/page-layout-problem.cc View 1 1 chunk +3 lines, -2 lines 1 comment Download
M lily/page-spacing-result.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/simple-spacer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/slur.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M lily/slur-configuration.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/stencil-integral.cc View 1 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 2
hanwenn
static_cast
3 weeks, 5 days ago (2020-02-02 15:07:20 UTC) #1
Dan Eble
3 weeks, 5 days ago (2020-02-02 18:44:52 UTC) #2
LGTM

https://codereview.appspot.com/563460043/diff/557300058/lily/page-layout-prob...
File lily/page-layout-problem.cc (right):

https://codereview.appspot.com/563460043/diff/557300058/lily/page-layout-prob...
lily/page-layout-problem.cc:739: = overflow / static_cast<Real> (space_count -
2);
This isn't an issue with this change, but does anyone see whether something
prevents division by zero here?  It isn't immediately obvious to me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b