Issue 555760043: Convert stencil to skyline directly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 555760043: Convert stencil to skyline directly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by hanwenn

Modified:
3 years, 11 months ago

Reviewers:
hahnjo

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Convert stencil to skyline directly Gets rid of more intermediate storage. eb3e0449f4 - Convert stencil to skyline directly baseline: 78d4ae8627 Thread skyline construction through stencil interpretation args: input/regression/mozart-hrn-3 memory: med diff -120 (stddevs 164 96, n=3) memory: med diff -0.0 % (eb3e0449f4 is neutral) time: med diff 0.00 (stddevs 0.01 0.01, n=3) time: med diff 0.0 % (eb3e0449f4 is neutral)

Patch Set 1 #

Patch Set 2 : oops. #

Patch Set 3 : rebase #

Total comments: 6

Patch Set 4 : rebase; jonas #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -98 lines)			Patch
	M	lily/stencil-integral.cc	View	1 2 3	4 chunks	+61 lines, -98 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

hahnjo

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode684 lily/stencil-integral.cc:684: if (false) this looks odd https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode692 lily/stencil-integral.cc:692: ; as ...

3 years, 12 months ago (2020-05-02 14:50:06 UTC) #3

hanwenn

3 years, 11 months ago (2020-05-02 21:44:27 UTC) #5

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral...
lily/stencil-integral.cc:684: if (false)
On 2020/05/02 14:50:06, hahnjo wrote:
> this looks odd

Done.

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral...
lily/stencil-integral.cc:692: ;
On 2020/05/02 14:50:06, hahnjo wrote:
> as all of the following conditions also compare head, I think this can be
> removed

Done.

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral...
lily/stencil-integral.cc:717: ;
On 2020/05/02 14:50:06, hahnjo wrote:
> same

Done.

Expand All Messages | Collapse All Messages