Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1028)

Issue 555760043: Convert stencil to skyline directly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by hanwenn
Modified:
4 weeks, 1 day ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Convert stencil to skyline directly Gets rid of more intermediate storage. eb3e0449f4 - Convert stencil to skyline directly baseline: 78d4ae8627 Thread skyline construction through stencil interpretation args: input/regression/mozart-hrn-3 memory: med diff -120 (stddevs 164 96, n=3) memory: med diff -0.0 % (eb3e0449f4 is neutral) time: med diff 0.00 (stddevs 0.01 0.01, n=3) time: med diff 0.0 % (eb3e0449f4 is neutral)

Patch Set 1 #

Patch Set 2 : oops. #

Patch Set 3 : rebase #

Total comments: 6

Patch Set 4 : rebase; jonas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -98 lines) Patch
M lily/stencil-integral.cc View 1 2 3 4 chunks +61 lines, -98 lines 0 comments Download

Messages

Total messages: 5
hanwenn
oops.
1 month, 1 week ago (2020-04-26 12:29:43 UTC) #1
hanwenn
rebase
1 month ago (2020-05-02 07:31:34 UTC) #2
hahnjo
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode684 lily/stencil-integral.cc:684: if (false) this looks odd https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode692 lily/stencil-integral.cc:692: ; as ...
1 month ago (2020-05-02 14:50:06 UTC) #3
hanwenn
rebase; jonas
1 month ago (2020-05-02 21:43:23 UTC) #4
hanwenn
1 month ago (2020-05-02 21:44:27 UTC) #5
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral...
lily/stencil-integral.cc:684: if (false)
On 2020/05/02 14:50:06, hahnjo wrote:
> this looks odd

Done.

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral...
lily/stencil-integral.cc:692: ;
On 2020/05/02 14:50:06, hahnjo wrote:
> as all of the following conditions also compare head, I think this can be
> removed

Done.

https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral...
lily/stencil-integral.cc:717: ;
On 2020/05/02 14:50:06, hahnjo wrote:
> same

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b