Code review - Issue 555760043: Convert stencil to skyline directlyhttps://codereview.appspot.com/2020-05-02T21:44:27+00:00rietveld
Message from unknown
2020-04-26T12:13:30+00:00hanwennurn:md5:24ae9a566c7d0c3f88ab628d8b9f9a36
Message from unknown
2020-04-26T12:29:42+00:00hanwennurn:md5:8035ecbc3ee35a19bae20a1d4be6cd29
Message from hanwenn@gmail.com
2020-04-26T12:29:43+00:00hanwennurn:md5:f7caf0400dab76d0fcc28d2f1f03bbb1
oops.
Message from unknown
2020-05-02T07:31:32+00:00hanwennurn:md5:e39f586f6dd37eff3ff02c893ca33826
Message from hanwenn@gmail.com
2020-05-02T07:31:34+00:00hanwennurn:md5:8dce976ff000969060cafd5c82399faf
rebase
Message from jonas.hahnfeld@gmail.com
2020-05-02T14:50:06+00:00hahnjourn:md5:ae146c2fdd34a0c163a3497cb5e46c36
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode684
lily/stencil-integral.cc:684: if (false)
this looks odd
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode692
lily/stencil-integral.cc:692: ;
as all of the following conditions also compare head, I think this can be removed
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode717
lily/stencil-integral.cc:717: ;
same
Message from unknown
2020-05-02T21:43:22+00:00hanwennurn:md5:17c7579d63ba649b819b410d4c65f036
Message from hanwenn@gmail.com
2020-05-02T21:43:23+00:00hanwennurn:md5:f09286708fc8154b0abb68efbf856a38
rebase; jonas
Message from hanwenn@gmail.com
2020-05-02T21:44:27+00:00hanwennurn:md5:a2e0eb579444903d1b7f961aebe44292
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode684
lily/stencil-integral.cc:684: if (false)
On 2020/05/02 14:50:06, hahnjo wrote:
> this looks odd
Done.
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode692
lily/stencil-integral.cc:692: ;
On 2020/05/02 14:50:06, hahnjo wrote:
> as all of the following conditions also compare head, I think this can be
> removed
Done.
https://codereview.appspot.com/555760043/diff/567530050/lily/stencil-integral.cc#newcode717
lily/stencil-integral.cc:717: ;
On 2020/05/02 14:50:06, hahnjo wrote:
> same
Done.