Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 55520043: code review 55520043: syscall: use unsafe.Pointer in BSD kevent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by bradfitz
Modified:
11 years, 1 month ago
Reviewers:
dvyukov
CC:
golang-codereviews, dvyukov, iant
Visibility:
Public.

Description

syscall: use unsafe.Pointer in BSD kevent Doesn't really matter for the most part, since the runtime-integrated network poller uses its own kevent implementation, but for people using the syscall directly, we should use an unsafe.Pointer for the precise GC to retain the pointer arguments. Also push down unsafe.Pointer a bit further in exec_linux.go, not that there are any GC preemption points in the middle and sys is still live anyway.

Patch Set 1 #

Patch Set 2 : diff -r 43646547a09c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 43646547a09c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 50235ae4e784 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -77 lines) Patch
M src/pkg/syscall/exec_linux.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/syscall/syscall_bsd.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/pkg/syscall/zsyscall_darwin_386.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_darwin_amd64.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_dragonfly_386.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_dragonfly_amd64.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_386.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_amd64.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_arm.go View 1 2 10 chunks +42 lines, -47 lines 0 comments Download
M src/pkg/syscall/zsyscall_netbsd_386.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_netbsd_amd64.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_netbsd_arm.go View 1 2 7 chunks +8 lines, -13 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_386.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_amd64.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-codereviews@googlegroups.com (cc: dvyukov@google.com, iant@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 1 month ago (2014-01-22 06:12:25 UTC) #1
dvyukov
LGTM
11 years, 1 month ago (2014-01-22 18:29:20 UTC) #2
bradfitz
11 years, 1 month ago (2014-01-22 18:35:47 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=e8949c1511da ***

syscall: use unsafe.Pointer in BSD kevent

Doesn't really matter for the most part, since the runtime-integrated
network poller uses its own kevent implementation, but for people using
the syscall directly, we should use an unsafe.Pointer for the precise GC
to retain the pointer arguments.

Also push down unsafe.Pointer a bit further in exec_linux.go, not
that there are any GC preemption points in the middle and sys
is still live anyway.

R=golang-codereviews, dvyukov
CC=golang-codereviews, iant
https://codereview.appspot.com/55520043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b