src/pkg/syscall/zsyscall_darwin_386.go - Issue 55520043: code review 55520043: syscall: use unsafe.Pointer in BSD kevent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/syscall/zsyscall_darwin_386.go

Issue 55520043: code review 55520043: syscall: use unsafe.Pointer in BSD kevent (Closed)

Patch Set: diff -r 50235ae4e784 https://go.googlecode.com/hg/ Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/syscall/zsyscall_darwin_386.go

===================================================================

--- a/src/pkg/syscall/zsyscall_darwin_386.go

+++ b/src/pkg/syscall/zsyscall_darwin_386.go

@@ -195,7 +195,7 @@

// THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT

-func kevent(kq int, change uintptr, nchange int, event uintptr, nevent int, timeout *Timespec) (n int, err error) {

+func kevent(kq int, change unsafe.Pointer, nchange int, event unsafe.Pointer, nevent int, timeout *Timespec) (n int, err error) {

r0, _, e1 := Syscall6(SYS_KEVENT, uintptr(kq), uintptr(change), uintptr(nchange), uintptr(event), uintptr(nevent), uintptr(unsafe.Pointer(timeout)))

n = int(r0)

if e1 != 0 {

« no previous file with comments | « src/pkg/syscall/syscall_bsd.go ('k') | src/pkg/syscall/zsyscall_darwin_amd64.go » ('j') | no next file with comments »