Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(556)

Issue 5536076: code review 5536076: database/sql: move from exp/sql (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by bradfitz
Modified:
12 years, 6 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

database/sql: move from exp/sql

Patch Set 1 #

Patch Set 2 : diff -r 985828084e10 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 985828084e10 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 8654c453394e https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/pkg/Makefile View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/database/sql/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/convert.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/convert_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/doc.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/database/sql/driver/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/database/sql/driver/driver.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/database/sql/driver/types.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/database/sql/driver/types_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/database/sql/fakedb_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/database/sql/sql.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
12 years, 6 months ago (2012-01-19 23:55:56 UTC) #1
r
LGTM assuming the deletions are just missing from codereview
12 years, 6 months ago (2012-01-19 23:58:50 UTC) #2
bradfitz
I'm going to wait to submit this until the tree is in a happier state. ...
12 years, 6 months ago (2012-01-20 00:02:56 UTC) #3
bradfitz
Nevermind, windows x64 just went "ok", and darwin is cool too. Linux multicast stuff can ...
12 years, 6 months ago (2012-01-20 00:04:09 UTC) #4
bradfitz
12 years, 6 months ago (2012-01-20 00:04:28 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=25879029ed5b ***

database/sql: move from exp/sql

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5536076
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b