I'm going to wait to submit this until the tree is in a happier state. ...
12 years, 11 months ago
(2012-01-20 00:02:56 UTC)
#3
I'm going to wait to submit this until the tree is in a happier state.
We have 3 different build failures now, and Windows hasn't gotten past the
FileMode CL, which I cross-compiled (some of) but never tested on Windows.
On Thu, Jan 19, 2012 at 3:58 PM, <r@golang.org> wrote:
> LGTM
> assuming the deletions are just missing from codereview
>
>
>
http://codereview.appspot.com/**5536076/<http://codereview.appspot.com/5536076/>
>
Nevermind, windows x64 just went "ok", and darwin is cool too. Linux multicast stuff can ...
12 years, 11 months ago
(2012-01-20 00:04:09 UTC)
#4
Nevermind, windows x64 just went "ok", and darwin is cool too. Linux
multicast stuff can be fixed later.
On Thu, Jan 19, 2012 at 4:02 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
> I'm going to wait to submit this until the tree is in a happier state.
>
> We have 3 different build failures now, and Windows hasn't gotten past the
> FileMode CL, which I cross-compiled (some of) but never tested on Windows.
>
>
> On Thu, Jan 19, 2012 at 3:58 PM, <r@golang.org> wrote:
>
>> LGTM
>> assuming the deletions are just missing from codereview
>>
>>
>>
http://codereview.appspot.com/**5536076/<http://codereview.appspot.com/5536076/>
>>
>
>
*** Submitted as http://code.google.com/p/go/source/detail?r=25879029ed5b *** database/sql: move from exp/sql R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5536076
12 years, 11 months ago
(2012-01-20 00:04:28 UTC)
#5
Issue 5536076: code review 5536076: database/sql: move from exp/sql
(Closed)
Created 12 years, 11 months ago by bradfitz
Modified 12 years, 11 months ago
Reviewers:
Base URL:
Comments: 0