Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(365)

Issue 553290043: Issue 5621: Improve rehearsal mark position at beginning of staff.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by lemzwerg
Modified:
2 months, 1 week ago
Reviewers:
Dan Eble, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5621: Improve rehearsal mark position at beginning of staff. This tiny change positions the rehearsal mark farther to the left at the beginning of a staff, thus no longer horizontally overlapping with the clef (which caused LilyPond to move the rehearsal mark up to avoid a collision).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scm/define-grobs.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
Dan Eble
I see many cases in the regression tests that this change fails to improve, for ...
2 months, 2 weeks ago (2019-12-11 01:06:19 UTC) #1
lemzwerg
> I see many cases in the regression tests that this > change fails to ...
2 months, 2 weeks ago (2019-12-11 06:16:17 UTC) #2
Dan Eble
Doesn't this shift _everything_ that one might try to align relative to a clef, not ...
2 months, 1 week ago (2019-12-14 16:47:15 UTC) #3
Dan Eble
On 2019/12/14 16:47:15, Dan Eble wrote: > I think it would be better for a ...
2 months, 1 week ago (2019-12-14 17:21:06 UTC) #4
Dan Eble
On 2019/12/14 16:47:15, Dan Eble wrote: > I think it would be better for a ...
2 months, 1 week ago (2019-12-14 19:54:05 UTC) #5
dak
nine.fierce.ballads@gmail.com writes: > On 2019/12/14 16:47:15, Dan Eble wrote: >> I think it would be ...
2 months, 1 week ago (2019-12-14 22:42:05 UTC) #6
Dan Eble
On 2019/12/14 22:42:05, dak wrote: > A callback function, if necessary due to early evaluation ...
2 months, 1 week ago (2019-12-15 01:32:18 UTC) #7
lemzwerg
2 months, 1 week ago (2019-12-15 06:33:45 UTC) #8
> See https://codereview.appspot.com/547340043/ .

Looks promising, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b