Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 547340043: Issue 5621: Improve rehearsal mark position at beginning of staff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by Dan Eble
Modified:
3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5621/ RehearsalMark uses a callback for self-alignment-X that yields the opposite of the direction specified by the anchor grob.

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove/revise some regtests #

Patch Set 3 : let MAKE_SCHEME_CALLBACK... handle overloading #

Patch Set 4 : clean up names, division between Scheme/C++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -53 lines) Patch
D input/regression/bar-scripts.ly View 1 1 chunk +0 lines, -20 lines 0 comments Download
M input/regression/pedal-bracket.ly View 1 1 chunk +1 line, -0 lines 0 comments Download
D input/regression/prefatory-empty-spacing.ly View 1 1 chunk +0 lines, -18 lines 0 comments Download
M lily/break-alignment-interface.cc View 1 2 3 3 chunks +61 lines, -13 lines 0 comments Download
M lily/include/break-align-interface.hh View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M lily/include/lily-guile-macros.hh View 1 2 2 chunks +41 lines, -1 line 0 comments Download
M scm/define-grobs.scm View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M scm/output-lib.scm View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17
Dan Eble
3 months, 3 weeks ago (2019-12-15 01:31:13 UTC) #1
lemzwerg
One early comment :-) https://codereview.appspot.com/547340043/diff/575390044/lily/break-alignment-interface.cc File lily/break-alignment-interface.cc (right): https://codereview.appspot.com/547340043/diff/575390044/lily/break-alignment-interface.cc#newcode328 lily/break-alignment-interface.cc:328: Break_alignable_interface::self_alignment_cis_breakable (SCM grob) Well, the ...
3 months, 3 weeks ago (2019-12-15 06:29:59 UTC) #2
Dan Eble
remove/revise some regtests
3 months, 3 weeks ago (2019-12-16 15:18:50 UTC) #3
Dan Eble
On 2019/12/16 15:18:50, Dan Eble wrote: > remove/revise some regtests Details: revise pedal-bracket.ly The mark ...
3 months, 3 weeks ago (2019-12-16 15:21:47 UTC) #4
Dan Eble
On 2019/12/15 06:29:59, lemzwerg wrote: > Well, the cis–trans pairing is IMHO only understandable for ...
3 months, 3 weeks ago (2019-12-16 16:51:59 UTC) #5
dak
On 2019/12/16 16:51:59, Dan Eble wrote: > On 2019/12/15 06:29:59, lemzwerg wrote: > > Well, ...
3 months, 3 weeks ago (2019-12-16 17:55:08 UTC) #6
pkx166h-lilypond
This patch passes make, make check and a full make doc. Dan's 17th Dec (2nd) ...
3 months, 3 weeks ago (2019-12-17 10:23:00 UTC) #7
Dan Eble
let MAKE_SCHEME_CALLBACK... handle overloading
3 months, 3 weeks ago (2019-12-17 14:02:19 UTC) #8
Dan Eble
clean up names, division between Scheme/C++
3 months, 3 weeks ago (2019-12-17 14:05:12 UTC) #9
Dan Eble
> let MAKE_SCHEME_CALLBACK... handle overloading This change lets me use both of these functions in ...
3 months, 3 weeks ago (2019-12-17 14:16:31 UTC) #10
Dan Eble
This is ready for a full review now. I don't think any new test cases ...
3 months, 3 weeks ago (2019-12-17 17:57:52 UTC) #11
dak
On 2019/12/17 17:57:52, Dan Eble wrote: > This is ready for a full review now. ...
3 months, 3 weeks ago (2019-12-17 18:49:41 UTC) #12
pkx166h-lilypond
This patch passes make, make check and a full make doc. diffs as follows Dan's ...
3 months, 3 weeks ago (2019-12-17 20:51:50 UTC) #13
Dan Eble
On 2019/12/17 18:49:41, dak wrote: > On 2019/12/17 17:57:52, Dan Eble wrote: > > I ...
3 months, 3 weeks ago (2019-12-19 21:27:45 UTC) #14
c_sorensen
On 12/19/19, 2:28 PM, "lilypond-devel on behalf of nine.fierce.ballads@gmail.com" <lilypond-devel-bounces+c_sorensen=byu.edu@gnu.org on behalf of nine.fierce.ballads@gmail.com> wrote: ...
3 months, 3 weeks ago (2019-12-19 21:39:20 UTC) #15
Dan Eble
On 2019/12/19 21:39:20, c_sorensen wrote: > Although I am not an expert in pure/impure calculations, ...
3 months, 2 weeks ago (2019-12-20 14:50:17 UTC) #16
Dan Eble
3 months, 2 weeks ago (2019-12-20 15:27:13 UTC) #17
On 2019/12/20 14:50:17, Dan Eble wrote:
> Can I play it safe by setting up a pure version of the callback that
> returns a constant value like before?  That would be pure, but I
> don't understand whether it would be better.

I tried this for RehearsalMark:

    ;; It's not clear whether having a pure version of
    ;; self-alignment-X is necessary or beneficial.
    (self-alignment-X . ,(ly:make-unpure-pure-container
                         
break-alignable-interface::self-alignment-opposite-of-anchor
                        CENTER))

It made no difference in the regression tests.  What are your
opinions on adding this to the patch?  Does it increase or
decrease your level of comfort?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b