Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4857)

Issue 546970043: Issue 5561/5562: slurs work without NoteHead stencil

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 2 weeks ago by Malte Meyn
Modified:
1 month, 2 weeks ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5561/5562: slurs work without NoteHead stencil While searching for slur configurations LilyPond crashed on NoteHeads without stencil because of empty extents. Also, when there cannot be found a viable slur config, this is reported as a warning rather than a failed assertion.

Patch Set 1 #

Patch Set 2 : corrected too long lines, no need to (re)test this patch set #

Total comments: 2

Patch Set 3 : apply the changes suggested by Dan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M lily/slur-scoring.cc View 1 2 5 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Malte Meyn
corrected too long lines, no need to (re)test this patch set
1 month, 2 weeks ago (2019-09-30 20:58:16 UTC) #1
Dan Eble
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc File lily/slur-scoring.cc (right): https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode352 lily/slur-scoring.cc:352: if (!state.configurations_.size ()) It's not necessary to change this, ...
1 month, 2 weeks ago (2019-10-01 12:42:55 UTC) #2
Malte Meyn
1 month, 2 weeks ago (2019-10-01 12:56:31 UTC) #3
apply the changes suggested by Dan
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b