Code review - Issue 546970043: Issue 5561/5562: slurs work without NoteHead stencilhttps://codereview.appspot.com/2019-10-01T12:56:31+00:00rietveld
Message from unknown
2019-09-30T20:13:09+00:00Malte Meynurn:md5:b5831c1768a019a317b9e55e278199b6
Message from unknown
2019-09-30T20:58:15+00:00Malte Meynurn:md5:198e4d83bbadc94fe9c2afd9848a7a63
Message from lilypond@maltemeyn.de
2019-09-30T20:58:16+00:00Malte Meynurn:md5:17fd636969c1e335fdfc62983a41b461
corrected too long lines, no need to (re)test this patch set
Message from nine.fierce.ballads@gmail.com
2019-10-01T12:42:55+00:00Dan Ebleurn:md5:6c50934fa8389ead9bfe6395effd38f6
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode352
lily/slur-scoring.cc:352: if (!state.configurations_.size ())
It's not necessary to change this, but I encourage you to cultivate a habit of using empty() in cases like this. empty() is a safer default because not all containers have an O(1) size(). empty() is also more readable, IMO.
https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode551
lily/slur-scoring.cc:551: if (isinf (x) || isnan (x))
https://en.cppreference.com/w/cpp/numeric/math/isfinite
Message from unknown
2019-10-01T12:56:30+00:00Malte Meynurn:md5:345d99e351fe38df870a8aa760c65b37
Message from lilypond@maltemeyn.de
2019-10-01T12:56:31+00:00Malte Meynurn:md5:c926f4e19f2839525d2edc296fc43d8f
apply the changes suggested by Dan