Issue 546970043: Issue 5561/5562: slurs work without NoteHead stencil

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 546970043: Issue 5561/5562: slurs work without NoteHead stencil

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 6 months ago by Malte Meyn

Modified:
4 years, 6 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5561/5562: slurs work without NoteHead stencil While searching for slur configurations LilyPond crashed on NoteHeads without stencil because of empty extents. Also, when there cannot be found a viable slur config, this is reported as a warning rather than a failed assertion.

Patch Set 1 #

Patch Set 2 : corrected too long lines, no need to (re)test this patch set #

Total comments: 2

Patch Set 3 : apply the changes suggested by Dan #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	lily/slur-scoring.cc	View	1 2	5 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Malte Meyn

corrected too long lines, no need to (re)test this patch set

4 years, 6 months ago (2019-09-30 20:58:16 UTC) #1

Dan Eble

https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc File lily/slur-scoring.cc (right): https://codereview.appspot.com/546970043/diff/552990043/lily/slur-scoring.cc#newcode352 lily/slur-scoring.cc:352: if (!state.configurations_.size ()) It's not necessary to change this, ...

4 years, 6 months ago (2019-10-01 12:42:55 UTC) #2

apply the changes suggested by Dan

Expand All Messages | Collapse All Messages