Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 5432077: Make 2-argument form of \accidentalStyle (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by dak
Modified:
7 years, 6 months ago
Reviewers:
pkx166h, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make 2-argument form of \accidentalStyle And run update-with-convert-ly.sh I am not all too happy with the syntax here, but can't think of anything reasonably better. Except possibly removing the ability of being able to specify a context altogether since the accidentalrules should know where to apply themselves without asking. Or checking (ly:output-description $defaultlayout) and accept only those symbols as context specification that are listed there. Or using a different command name for the two-argument case. But I like all those alternatives even worse.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M Documentation/de/notation/pitches.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/ja/notation/pitches.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M Documentation/notation/pitches.itely View 4 chunks +4 lines, -4 lines 0 comments Download
M ly/property-init.ly View 1 chunk +9 lines, -5 lines 0 comments Download
M python/convertrules.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2
pkx166h
Passes Make and make check James
7 years, 7 months ago (2011-11-25 21:10:11 UTC) #1
Carl
7 years, 7 months ago (2011-11-28 01:27:21 UTC) #2
LGTM.

I agree with you about the 2-argument form being the least obnoxious of the
alternatives.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b