Issue 5312054: Fix component build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5312054: Fix component build

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by piman

Modified:
12 years, 6 months ago

Reviewers:
apatrick1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk

Visibility:
Public.

Description

Fix component build BUG=None TEST=Try bots

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/build_angle.gyp	View		3 chunks	+2 lines, -1 line	0 comments	Download
	M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

piman

http://codereview.appspot.com/5305053 missed a part of the change that is needed to get libGLESv2.lib to link ...

12 years, 6 months ago (2011-10-24 20:49:57 UTC) #1

apatrick1

Oops. I still have that change and there are some other bits and pieces in ...

12 years, 6 months ago (2011-10-24 21:07:02 UTC) #2

piman

12 years, 6 months ago (2011-10-24 22:12:58 UTC) #3

On Mon, Oct 24, 2011 at 2:07 PM, <apatrick@chromium.org> wrote:

> Oops. I still have that change and there are some other bits and pieces
> in build_angle.gyp. Do you still want those changes?


> It's here
http://codereview.appspot.com/**5318051/<http://codereview.appspot.com/5318051/>
>
>
Yes! Disregard this CL, use yours instead.

Antoine


>
http://codereview.appspot.com/**5312054/<http://codereview.appspot.com/5312054/>
>

Expand All Messages | Collapse All Messages