Issue 5305053: Allowed translator_hlsl and glsl to be built as shared libs on windows.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305053: Allowed translator_hlsl and glsl to be built as shared libs on windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by apatrick1

Modified:
12 years, 6 months ago

Reviewers:
kbr1, piman

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Allowed translator_hlsl and glsl to be built as shared libs on windows. The problem was gyp was out-of-date (I rolled it to 1080) and ShaderLang.cpp exports were not being exported because it was in translator_common which is a static lib. I tested shared library and static library builds in debug and release and also the checked in ANGLE.sln build. See original attempt: http://codereview.appspot.com/5305052/. Committed: http://code.google.com/p/angleproject/source/detail?r=801

Patch Set 1 : '' #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -28 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/common.gypi	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	include/GLSLANG/ShaderLang.h	View	10 chunks	+46 lines, -25 lines	0 comments	Download
M	src/common/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

piman

On 2011/10/21 00:58:36, apatrick1 wrote: > PTAL LGTM. I tried on linux and seems to ...

12 years, 6 months ago (2011-10-21 01:03:48 UTC) #2

LGTM

Expand All Messages | Collapse All Messages