Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2252)

Issue 5297042: code review 5297042: [release-branch.r58] reflect: disallow Interface method... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

[release-branch.r58] reflect: disallow Interface method on Value obtained via unexported name Also remove exp/datafmt that depends on the broken reflect behavior. ««« CL 5267049 / eeca0d4a91a3 reflect: disallow Interface method on Value obtained via unexported name Had been allowing it for use by fmt, but it is too hard to lock down. Fix other packages not to depend on it. R=r, r CC=golang-dev http://codereview.appspot.com/5266054 »»»

Patch Set 1 #

Patch Set 2 : diff -r d292bc788668 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d292bc788668 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -1645 lines) Patch
M src/pkg/Makefile View 1 1 chunk +0 lines, -1 line 0 comments Download
R src/pkg/exp/datafmt/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/exp/datafmt/datafmt.go View 1 1 chunk +0 lines, -731 lines 0 comments Download
R src/pkg/exp/datafmt/datafmt_test.go View 1 1 chunk +0 lines, -351 lines 0 comments Download
R src/pkg/exp/datafmt/parser.go View 1 1 chunk +0 lines, -386 lines 0 comments Download
M src/pkg/fmt/fmt_test.go View 5 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/fmt/print.go View 22 chunks +151 lines, -94 lines 0 comments Download
M src/pkg/reflect/all_test.go View 4 chunks +90 lines, -25 lines 0 comments Download
M src/pkg/reflect/deepequal.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/reflect/value.go View 3 chunks +15 lines, -16 lines 0 comments Download
M test/interface/fake.go View 2 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 4 months ago (2011-10-18 02:56:04 UTC) #1
dsymonds
LGTM
9 years, 4 months ago (2011-10-18 03:01:37 UTC) #2
adg
9 years, 4 months ago (2011-10-18 03:06:20 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=acaddf1cea75 ***

[release-branch.r58] reflect: disallow Interface method on Value obtained via
unexported name

Also remove exp/datafmt that depends on the broken reflect behavior.

««« CL 5267049 / eeca0d4a91a3
reflect: disallow Interface method on Value obtained via unexported name

Had been allowing it for use by fmt, but it is too hard to lock down.
Fix other packages not to depend on it.

R=r, r
CC=golang-dev
http://codereview.appspot.com/5266054
»»»

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5297042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b