Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(40)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Unified Diff: src/pkg/Makefile
Issue
5297042
:
code review 5297042: [release-branch.r58] reflect: disallow Interface method... (Closed)
Patch Set: diff -r d292bc788668 https://go.googlecode.com/hg/
Created 13 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
src/pkg/Makefile
src/pkg/exp/datafmt/Makefile
src/pkg/exp/datafmt/datafmt.go
src/pkg/exp/datafmt/datafmt_test.go
src/pkg/exp/datafmt/parser.go
src/pkg/fmt/fmt_test.go
src/pkg/fmt/print.go
src/pkg/reflect/all_test.go
src/pkg/reflect/deepequal.go
src/pkg/reflect/value.go
test/interface/fake.go
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« no previous file
|
src/pkg/exp/datafmt/Makefile »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: src/pkg/Makefile
===================================================================
--- a/src/pkg/Makefile
+++ b/src/pkg/Makefile
@@ -76,7 +76,6 @@
encoding/hex\
encoding/pem\
exec\
- exp/datafmt\
exp/eval\
exp/gui\
exp/gui/x11\
« no previous file with comments
|
« no previous file
|
src/pkg/exp/datafmt/Makefile »
('j') |
no next file with comments »
Issue 5297042: code review 5297042: [release-branch.r58] reflect: disallow Interface method... (Closed)
Created 13 years, 5 months ago by adg
Modified 13 years, 5 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b