Code review - Issue 5297042: code review 5297042: [release-branch.r58] reflect: disallow Interface method...https://codereview.appspot.com/2011-10-18T03:06:20+00:00rietveld
Message from unknown
2011-10-18T02:55:51+00:00adgurn:md5:c457435ced3a840e684f58eed5bcbb1a
Message from adg@golang.org
2011-10-18T02:56:04+00:00adgurn:md5:1760042f727cc4dcc18a0aeae992cc56
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from unknown
2011-10-18T02:59:01+00:00adgurn:md5:df4e4e77f894510c3c4fa837241c526b
Message from dsymonds@golang.org
2011-10-18T03:01:37+00:00dsymondsurn:md5:f7bee2e108168c40c00ca1eaf844dd3d
LGTM
Message from unknown
2011-10-18T03:05:54+00:00adgurn:md5:684fe241d099df77cc73e0e54c31e209
Message from adg@golang.org
2011-10-18T03:06:20+00:00adgurn:md5:f5bf9ac9308e6b04a9d3dcdf0f6b4544
*** Submitted as http://code.google.com/p/go/source/detail?r=acaddf1cea75 ***
[release-branch.r58] reflect: disallow Interface method on Value obtained via unexported name
Also remove exp/datafmt that depends on the broken reflect behavior.
««« CL 5267049 / eeca0d4a91a3
reflect: disallow Interface method on Value obtained via unexported name
Had been allowing it for use by fmt, but it is too hard to lock down.
Fix other packages not to depend on it.
R=r, r
CC=golang-dev
http://codereview.appspot.com/5266054
»»»
R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5297042