Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(110)

Issue 51690043: code review 51690043: go.crypto/ssh/terminal: enable freebsd build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by ebfe
Modified:
5 years, 7 months ago
Reviewers:
dfc, bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

go.crypto/ssh/terminal: enable freebsd build syscall.Termios, which was the only thing breaking the build, is available in go tip now (https://code.google.com/p/go/source/detail?r=873d664b00ec)

Patch Set 1 #

Patch Set 2 : diff -r 6478cc9340cb https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 6478cc9340cb https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ssh/terminal/util.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssh/terminal/util_bsd.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
ebfe
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
5 years, 8 months ago (2014-01-13 22:31:07 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
5 years, 8 months ago (2014-01-13 22:33:50 UTC) #2
bradfitz
LGTM On Mon, Jan 13, 2014 at 2:31 PM, <gnirheg.leahcim@gmail.com> wrote: > Reviewers: golang-dev, > ...
5 years, 8 months ago (2014-01-13 22:33:57 UTC) #3
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=abf8f8812575&repo=crypto *** go.crypto/ssh/terminal: enable freebsd build syscall.Termios, which was the only thing ...
5 years, 8 months ago (2014-01-13 22:35:21 UTC) #4
dfc
Not LGTM, now this package doesn't pass tests for FreeBSD uses who aren't running tip.
5 years, 8 months ago (2014-01-13 22:48:51 UTC) #5
bradfitz
Sigh. I figured it was harmless since this package wasn't even usable on FreeBSD before. ...
5 years, 8 months ago (2014-01-13 22:51:51 UTC) #6
dfc
Let's role this change back and merge it into Han-Wen's gosshnew fork, which should be ...
5 years, 8 months ago (2014-01-13 22:56:00 UTC) #7
bradfitz
5 years, 8 months ago (2014-01-13 22:58:32 UTC) #8
https://codereview.appspot.com/51100044


On Mon, Jan 13, 2014 at 2:55 PM, Dave Cheney <dave@cheney.net> wrote:

> Let's role this change back and merge it into Han-Wen's gosshnew fork,
> which should be merged by 1.3.
>
> On 14 Jan 2014, at 9:51, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>
> Sigh. I figured it was harmless since this package wasn't even usable on
> FreeBSD before.
>
> I guess we need freebsd,!go1.2 but go tip is also tagged "go1.2" and we
> don't have a "gotip" build tag.
>
> Suggestions?
>
>
>
> On Mon, Jan 13, 2014 at 2:48 PM, Dave Cheney <dave@cheney.net> wrote:
>
>> Not LGTM, now this package doesn't pass tests for FreeBSD uses who aren't
>> running tip.
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b