code review 51690043: go.crypto/ssh/terminal: enable freebsd build

go.crypto/ssh/terminal: enable freebsd build

syscall.Termios, which was the only thing breaking the build, is
available in go tip now
(https://code.google.com/p/go/source/detail?r=873d664b00ec)

[ebfe, 2014-01-13 22:31:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[gobot, 2014-01-13 22:33:50]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[bradfitz, 2014-01-13 22:33:57]

LGTM



On Mon, Jan 13, 2014 at 2:31 PM, <gnirheg.leahcim@gmail.com> wrote:

> Reviewers: golang-dev,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.crypto
>
>
> Description:
> go.crypto/ssh/terminal: enable freebsd build
>
> syscall.Termios, which was the only thing breaking the build, is
> available in go tip now
> (https://code.google.com/p/go/source/detail?r=873d664b00ec)
>
> Please review this at https://codereview.appspot.com/51690043/
>
> Affected files (+2, -2 lines):
>   M ssh/terminal/util.go
>   M ssh/terminal/util_bsd.go
>
>
> Index: ssh/terminal/util.go
> ===================================================================
> --- a/ssh/terminal/util.go
> +++ b/ssh/terminal/util.go
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -// +build linux,!appengine darwin
> +// +build linux,!appengine darwin freebsd
>
>  // Package terminal provides support functions for dealing with
> terminals, as
>  // commonly found on UNIX systems.
> Index: ssh/terminal/util_bsd.go
> ===================================================================
> --- a/ssh/terminal/util_bsd.go
> +++ b/ssh/terminal/util_bsd.go
> @@ -2,7 +2,7 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> -// +build darwin
> +// +build darwin freebsd
>
>  package terminal
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[bradfitz, 2014-01-13 22:35:21]

*** Submitted as
https://code.google.com/p/go/source/detail?r=abf8f8812575&repo=crypto ***

go.crypto/ssh/terminal: enable freebsd build

syscall.Termios, which was the only thing breaking the build, is
available in go tip now
(https://code.google.com/p/go/source/detail?r=873d664b00ec)

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/51690043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[dfc, 2014-01-13 22:48:51]

Not LGTM, now this package doesn't pass tests for FreeBSD uses who aren't
running tip. 

[bradfitz, 2014-01-13 22:51:51]

Sigh. I figured it was harmless since this package wasn't even usable on
FreeBSD before.

I guess we need freebsd,!go1.2 but go tip is also tagged "go1.2" and we
don't have a "gotip" build tag.

Suggestions?



On Mon, Jan 13, 2014 at 2:48 PM, Dave Cheney <dave@cheney.net> wrote:

> Not LGTM, now this package doesn't pass tests for FreeBSD uses who aren't
> running tip.

[dfc, 2014-01-13 22:56:00]

Let's role this change back and merge it into Han-Wen's gosshnew fork, which
should be merged by 1.3. 

> On 14 Jan 2014, at 9:51, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> 
> Sigh. I figured it was harmless since this package wasn't even usable on
FreeBSD before.
> 
> I guess we need freebsd,!go1.2 but go tip is also tagged "go1.2" and we don't
have a "gotip" build tag.
> 
> Suggestions?
> 
> 
> 
>> On Mon, Jan 13, 2014 at 2:48 PM, Dave Cheney <dave@cheney.net> wrote:
>> Not LGTM, now this package doesn't pass tests for FreeBSD uses who aren't
running tip.
> 

[bradfitz, 2014-01-13 22:58:32]

https://codereview.appspot.com/51100044


On Mon, Jan 13, 2014 at 2:55 PM, Dave Cheney <dave@cheney.net> wrote:

> Let's role this change back and merge it into Han-Wen's gosshnew fork,
> which should be merged by 1.3.
>
> On 14 Jan 2014, at 9:51, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>
> Sigh. I figured it was harmless since this package wasn't even usable on
> FreeBSD before.
>
> I guess we need freebsd,!go1.2 but go tip is also tagged "go1.2" and we
> don't have a "gotip" build tag.
>
> Suggestions?
>
>
>
> On Mon, Jan 13, 2014 at 2:48 PM, Dave Cheney <dave@cheney.net> wrote:
>
>> Not LGTM, now this package doesn't pass tests for FreeBSD uses who aren't
>> running tip.
>
>
>