Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 51100044: code review 51100044: undo CL 51690043 / abf8f8812575 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by bradfitz
Modified:
5 years, 8 months ago
Reviewers:
dfc
CC:
golang-codereviews, dfc
Visibility:
Public.

Description

undo CL 51690043 / abf8f8812575 Breaks FreeBSD build of subrepo for non-tip users. ««« original CL description go.crypto/ssh/terminal: enable freebsd build syscall.Termios, which was the only thing breaking the build, is available in go tip now (https://code.google.com/p/go/source/detail?r=873d664b00ec) R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/51690043 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r abf8f8812575 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r abf8f8812575 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ssh/terminal/util.go View 1 1 chunk +1 line, -1 line 0 comments Download
M ssh/terminal/util_bsd.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
5 years, 8 months ago (2014-01-13 22:58:29 UTC) #1
dfc
LGTM. Thank you. > On 14 Jan 2014, at 9:58, bradfitz@golang.org wrote: > > Reviewers: ...
5 years, 8 months ago (2014-01-13 22:59:39 UTC) #2
bradfitz
5 years, 8 months ago (2014-01-13 23:00:52 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=61c59dda830a&repo=crypto ***

undo CL 51690043 / abf8f8812575

Breaks FreeBSD build of subrepo for non-tip users.

««« original CL description
go.crypto/ssh/terminal: enable freebsd build

syscall.Termios, which was the only thing breaking the build, is
available in go tip now
(https://code.google.com/p/go/source/detail?r=873d664b00ec)

R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/51690043

Committer: Brad Fitzpatrick <bradfitz@golang.org>
»»»

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/51100044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b