Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(599)

Issue 5136050: code review 5136050: This changes are due to change in the color.go file. Ne...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Kishore Bodagala
Modified:
6 months, 3 weeks ago
Reviewers:
nigel tao <nigeltao
CC:
golang-dev
Visibility:
Public.

Description

This changes are due to change in the color.go file. New structure for color formats. There is color plane buffer array changed to structure. Due to this change all the places where the color arthematic gone wrong. So i tried my level best to correct and test all the places. But, I could not able to find how to solve for /jpeg and /tiff images. May be I will take more time to solve it. So I would like to send this big change list for review and work on the other problems. If you find the solution plese fix in the /jpeg and /tiff This is my first check in. By mistake I checked in unmodified files also. Please ignore them while doing review.

Patch Set 1 #

Patch Set 2 : diff -r 6c5c19791fae https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -270 lines) Patch
M src/pkg/Makefile View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/exp/gui/x11/conn.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/image/Makefile View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/image/bmp/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/bmp/reader.go View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/image/color.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/decode_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/draw/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/draw/bench_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/draw/clip_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/draw/draw.go View 1 13 chunks +108 lines, -108 lines 0 comments Download
M src/pkg/image/draw/draw_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/format.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/geom.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/gif/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/gif/reader.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/image.go View 1 38 chunks +131 lines, -151 lines 0 comments Download
M src/pkg/image/image_test.go View 1 2 chunks +13 lines, -13 lines 0 comments Download
M src/pkg/image/jpeg/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/jpeg/fdct.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/jpeg/huffman.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/jpeg/idct.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/jpeg/reader.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/image/jpeg/writer.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/image/jpeg/writer_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/names.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/png/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/png/reader.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/png/reader_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/png/writer.go View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/pkg/image/png/writer_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/tiff/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/tiff/buffer.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/tiff/buffer_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/tiff/consts.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/tiff/reader.go View 1 3 chunks +11 lines, -9 lines 0 comments Download
M src/pkg/image/tiff/reader_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/ycbcr/Makefile View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/ycbcr/ycbcr.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/image/ycbcr/ycbcr_test.go View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
Kishore Bodagala
Hello legoff.laurent@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
6 years, 2 months ago (2011-09-28 07:56:51 UTC) #1
llg
On 2011/09/28 07:56:51, Kishore Bodagala wrote: > Hello mailto:legoff.laurent@gmail.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...
6 years, 2 months ago (2011-09-28 08:32:32 UTC) #2
llg
6 years, 2 months ago (2011-09-28 08:36:01 UTC) #3
Hi Kishore,

you've made a huge work, but there's a big problem. You have modified the source
code of the internal go image package. I'm not responsible of this package and
we do not have to change this package. The change have to be made in draw2d
package and is a minor change compared to what you've done with image package.
Sorry I 've misunderstood your last mails.
The change have to be written in this file :
http://code.google.com/p/draw2d/source/browse/draw2d/paint.go not in image
package.


sorry for the confusion, and keep it simple.
Laurent


Le 28 sept. 2011 à 09:56, kishoreBE@gmail.com a écrit :

> Reviewers: llg,
> 
> Message:
> Hello legoff.laurent@gmail.com (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go/
> 
> 
> Description:
> This changes are due to change in the color.go file. New structure for
> color formats.
> 
> There is color plane buffer array changed to structure.
> Due to this change all the places where the color arthematic
> gone wrong. So i tried my level best to correct and test all the
> places.
> But, I could not able to find how to solve for /jpeg and /tiff
> images. May be I will take more time to solve it.
> So I would like to send this big change list for review and work
> on the other problems.
> If you find the solution plese fix in the /jpeg and /tiff
> 
> Please review this at http://codereview.appspot.com/5136050/
> 
> Affected files:
>  M src/pkg/Makefile
>  M src/pkg/exp/gui/x11/conn.go
>  M src/pkg/image/Makefile
>  M src/pkg/image/bmp/Makefile
>  M src/pkg/image/bmp/reader.go
>  M src/pkg/image/color.go
>  M src/pkg/image/decode_test.go
>  M src/pkg/image/draw/Makefile
>  M src/pkg/image/draw/bench_test.go
>  M src/pkg/image/draw/clip_test.go
>  M src/pkg/image/draw/draw.go
>  M src/pkg/image/draw/draw_test.go
>  M src/pkg/image/format.go
>  M src/pkg/image/geom.go
>  M src/pkg/image/gif/Makefile
>  M src/pkg/image/gif/reader.go
>  M src/pkg/image/image.go
>  M src/pkg/image/image_test.go
>  M src/pkg/image/jpeg/Makefile
>  M src/pkg/image/jpeg/fdct.go
>  M src/pkg/image/jpeg/huffman.go
>  M src/pkg/image/jpeg/idct.go
>  M src/pkg/image/jpeg/reader.go
>  M src/pkg/image/jpeg/writer.go
>  M src/pkg/image/jpeg/writer_test.go
>  M src/pkg/image/names.go
>  M src/pkg/image/png/Makefile
>  M src/pkg/image/png/reader.go
>  M src/pkg/image/png/reader_test.go
>  M src/pkg/image/png/writer.go
>  M src/pkg/image/png/writer_test.go
>  M src/pkg/image/tiff/Makefile
>  M src/pkg/image/tiff/buffer.go
>  M src/pkg/image/tiff/buffer_test.go
>  M src/pkg/image/tiff/consts.go
>  M src/pkg/image/tiff/reader.go
>  M src/pkg/image/tiff/reader_test.go
>  M src/pkg/image/ycbcr/Makefile
>  M src/pkg/image/ycbcr/ycbcr.go
>  M src/pkg/image/ycbcr/ycbcr_test.go
> 
> 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d