Code review - Issue 5136050: code review 5136050: This changes are due to change in the color.go file. Ne...https://codereview.appspot.com/2011-09-28T08:36:01+00:00rietveld
Message from unknown
2011-09-28T07:51:31+00:00Kishore Bodagalaurn:md5:7739d8f63ceec810d28bd73212352961
Message from unknown
2011-09-28T07:56:42+00:00Kishore Bodagalaurn:md5:b521182f74ebd49509427d9fdae5f96c
Message from kishoreBE@gmail.com
2011-09-28T07:56:51+00:00Kishore Bodagalaurn:md5:03ac67fcb386bbb36c33b65c54473c5f
Hello legoff.laurent@gmail.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go/
Message from legoff.laurent@gmail.com
2011-09-28T08:32:32+00:00llgurn:md5:3b6d0262b16798049724c5d93ecff3fb
On 2011/09/28 07:56:51, Kishore Bodagala wrote:
> Hello mailto:legoff.laurent@gmail.com (cc: mailto:golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
not appropriate.
Message from legoff.laurent@gmail.com
2011-09-28T08:36:01+00:00llgurn:md5:7453d06f7da71c01d2cf5a4b9dc9b0fa
Hi Kishore,
you've made a huge work, but there's a big problem. You have modified the source code of the internal go image package. I'm not responsible of this package and we do not have to change this package. The change have to be made in draw2d package and is a minor change compared to what you've done with image package. Sorry I 've misunderstood your last mails.
The change have to be written in this file : http://code.google.com/p/draw2d/source/browse/draw2d/paint.go not in image package.
sorry for the confusion, and keep it simple.
Laurent
Le 28 sept. 2011 à 09:56, kishoreBE@gmail.com a écrit :
> Reviewers: llg,
>
> Message:
> Hello legoff.laurent@gmail.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> This changes are due to change in the color.go file. New structure for
> color formats.
>
> There is color plane buffer array changed to structure.
> Due to this change all the places where the color arthematic
> gone wrong. So i tried my level best to correct and test all the
> places.
> But, I could not able to find how to solve for /jpeg and /tiff
> images. May be I will take more time to solve it.
> So I would like to send this big change list for review and work
> on the other problems.
> If you find the solution plese fix in the /jpeg and /tiff
>
> Please review this at http://codereview.appspot.com/5136050/
>
> Affected files:
> M src/pkg/Makefile
> M src/pkg/exp/gui/x11/conn.go
> M src/pkg/image/Makefile
> M src/pkg/image/bmp/Makefile
> M src/pkg/image/bmp/reader.go
> M src/pkg/image/color.go
> M src/pkg/image/decode_test.go
> M src/pkg/image/draw/Makefile
> M src/pkg/image/draw/bench_test.go
> M src/pkg/image/draw/clip_test.go
> M src/pkg/image/draw/draw.go
> M src/pkg/image/draw/draw_test.go
> M src/pkg/image/format.go
> M src/pkg/image/geom.go
> M src/pkg/image/gif/Makefile
> M src/pkg/image/gif/reader.go
> M src/pkg/image/image.go
> M src/pkg/image/image_test.go
> M src/pkg/image/jpeg/Makefile
> M src/pkg/image/jpeg/fdct.go
> M src/pkg/image/jpeg/huffman.go
> M src/pkg/image/jpeg/idct.go
> M src/pkg/image/jpeg/reader.go
> M src/pkg/image/jpeg/writer.go
> M src/pkg/image/jpeg/writer_test.go
> M src/pkg/image/names.go
> M src/pkg/image/png/Makefile
> M src/pkg/image/png/reader.go
> M src/pkg/image/png/reader_test.go
> M src/pkg/image/png/writer.go
> M src/pkg/image/png/writer_test.go
> M src/pkg/image/tiff/Makefile
> M src/pkg/image/tiff/buffer.go
> M src/pkg/image/tiff/buffer_test.go
> M src/pkg/image/tiff/consts.go
> M src/pkg/image/tiff/reader.go
> M src/pkg/image/tiff/reader_test.go
> M src/pkg/image/ycbcr/Makefile
> M src/pkg/image/ycbcr/ycbcr.go
> M src/pkg/image/ycbcr/ycbcr_test.go
>
>