Issue 4963063: Replace the Request/Response Context after each ServletModule-registered Filter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4963063: Replace the Request/Response Context after each ServletModule-registered Filter.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by isaac.q.shum

Modified:
2 years, 8 months ago

Reviewers:
jessewilson1, dhanji, sameb

Base URL:
http://google-guice.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Replace the Request/Response Context after each ServletModule-registered Filter. This fixes a bunch of duplicate bugs: http://code.google.com/p/google-guice/issues/detail?id=566 http://code.google.com/p/google-guice/issues/detail?id=596 http://code.google.com/p/google-guice/issues/detail?id=648

Patch Set 1 #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+322 lines, -150 lines)			Patch
M	extensions/servlet/src/com/google/inject/servlet/FilterChainInvocation.java	View	2 chunks	+21 lines, -10 lines	0 comments	Download
M	extensions/servlet/src/com/google/inject/servlet/GuiceFilter.java	View	3 chunks	+20 lines, -9 lines	0 comments	Download
M	extensions/servlet/src/com/google/inject/servlet/ManagedFilterPipeline.java	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	extensions/servlet/src/com/google/inject/servlet/ManagedServletPipeline.java	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	extensions/servlet/src/com/google/inject/servlet/ServletDefinition.java	View	4 chunks	+24 lines, -7 lines	0 comments	Download
M	extensions/servlet/src/com/google/inject/servlet/ServletScopes.java	View	7 chunks	+22 lines, -5 lines	0 comments	Download
M	extensions/servlet/test/com/google/inject/servlet/ServletTest.java	View	9 chunks	+227 lines, -109 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

isaac.q.shum

12 years, 7 months ago (2011-09-08 00:30:34 UTC) #1

Hey Dhanji, you're still the Servlet expert, so your advice is much appreciated.

FYI I believe that this means that all Filters have to support
HttpServletRequest/HttpServletResponse vs. just ServletRequest/ServletResponse. 
I wasn't sure if we actually supported non-http,  but that was suggested in some
of the comments.

Expand All Messages | Collapse All Messages