Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 4963063: Replace the Request/Response Context after each ServletModule-registered Filter.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by isaac.q.shum
Modified:
1 month, 1 week ago
Reviewers:
jessewilson1, dhanji, sameb
Base URL:
http://google-guice.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Replace the Request/Response Context after each ServletModule-registered Filter. This fixes a bunch of duplicate bugs: http://code.google.com/p/google-guice/issues/detail?id=566 http://code.google.com/p/google-guice/issues/detail?id=596 http://code.google.com/p/google-guice/issues/detail?id=648

Patch Set 1 #

Messages

Total messages: 1
isaac.q.shum
10 years ago (2011-09-08 00:30:34 UTC) #1
Hey Dhanji, you're still the Servlet expert, so your advice is much appreciated.

FYI I believe that this means that all Filters have to support
HttpServletRequest/HttpServletResponse vs. just ServletRequest/ServletResponse. 
I wasn't sure if we actually supported non-http,  but that was suggested in some
of the comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b