Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1442)

Unified Diff: extensions/servlet/src/com/google/inject/servlet/ManagedServletPipeline.java

Issue 4963063: Replace the Request/Response Context after each ServletModule-registered Filter. Base URL: http://google-guice.googlecode.com/svn/trunk/
Patch Set: Created 12 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/servlet/src/com/google/inject/servlet/ManagedServletPipeline.java
===================================================================
--- extensions/servlet/src/com/google/inject/servlet/ManagedServletPipeline.java (revision 1577)
+++ extensions/servlet/src/com/google/inject/servlet/ManagedServletPipeline.java (working copy)
@@ -139,21 +139,20 @@
requestToProcess = servletRequest;
}
- servletRequest.setAttribute(REQUEST_DISPATCHER_REQUEST, Boolean.TRUE);
-
// now dispatch to the servlet
- try {
- servletDefinition.doService(requestToProcess, servletResponse);
- } finally {
- servletRequest.removeAttribute(REQUEST_DISPATCHER_REQUEST);
- }
+ doServiceImpl(servletDefinition, requestToProcess, servletResponse);
}
public void include(ServletRequest servletRequest, ServletResponse servletResponse)
throws ServletException, IOException {
+ // route to the target servlet
+ doServiceImpl(servletDefinition, servletRequest, servletResponse);
+ }
+
+ private void doServiceImpl(ServletDefinition servletDefinition, ServletRequest servletRequest,
+ ServletResponse servletResponse) throws ServletException, IOException {
servletRequest.setAttribute(REQUEST_DISPATCHER_REQUEST, Boolean.TRUE);
- // route to the target servlet
try {
servletDefinition.doService(servletRequest, servletResponse);
} finally {

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b