code review 46470043: crypto/sha256: add tests for Size() and BlockSize()

crypto/sha256: add tests for Size() and BlockSize()

[shawnps, 2013-12-30 11:59:38]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[shawnps, 2013-12-30 12:00:11]

On 2013/12/30 11:59:38, shawnps wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Should this be combined with the crypto/sha1 CL here?
https://codereview.appspot.com/46400044

[dave_cheney.net, 2013-12-31 20:24:47]

LGTM.

Before:
coverage: 94.4% of statements
ok      crypto/sha256   0.007s
crypto/sha256/sha256.go:        init            100.0%
crypto/sha256/sha256.go:        Reset           100.0%
crypto/sha256/sha256.go:        New             100.0%
crypto/sha256/sha256.go:        New224          100.0%
crypto/sha256/sha256.go:        Size            0.0%
crypto/sha256/sha256.go:        BlockSize       0.0%
crypto/sha256/sha256.go:        Write           100.0%
crypto/sha256/sha256.go:        Sum             100.0%
crypto/sha256/sha256.go:        checkSum        95.5%
crypto/sha256/sha256.go:        Sum256          100.0%
crypto/sha256/sha256.go:        Sum224          100.0%
total:                          (statements)    94.4%

After:
lucky(~/go/src/pkg/crypto/sha256) % cover
PASS
coverage: 98.9% of statements
ok      crypto/sha256   0.007s
crypto/sha256/sha256.go:        init            100.0%
crypto/sha256/sha256.go:        Reset           100.0%
crypto/sha256/sha256.go:        New             100.0%
crypto/sha256/sha256.go:        New224          100.0%
crypto/sha256/sha256.go:        Size            100.0%
crypto/sha256/sha256.go:        BlockSize       100.0%
crypto/sha256/sha256.go:        Write           100.0%
crypto/sha256/sha256.go:        Sum             100.0%
crypto/sha256/sha256.go:        checkSum        95.5%
crypto/sha256/sha256.go:        Sum256          100.0%
crypto/sha256/sha256.go:        Sum224          100.0%
total:                          (statements)    98.9%

[dave_cheney.net, 2013-12-31 20:46:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=58deb42f814a ***

crypto/sha256: add tests for Size() and BlockSize()

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/46470043

Committer: Dave Cheney <dave@cheney.net>