Issue 46400044: code review 46400044: crypto/sha1: add tests for Size() and BlockSize()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46400044: code review 46400044: crypto/sha1: add tests for Size() and BlockSize()

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by shawnps

Modified:
11 years, 6 months ago

Reviewers:
dave

CC:
golang-codereviews, dave_cheney.net

Visibility:
Public.

Description

crypto/sha1: add tests for Size() and BlockSize()

Patch Set 1 #

Patch Set 2 : diff -r b3caf13d930b https://code.google.com/p/go #

Patch Set 3 : diff -r b3caf13d930b https://code.google.com/p/go #

Patch Set 4 : diff -r 959a83dadbb9 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	src/pkg/crypto/sha1/sha1_test.go	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

shawnps

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-12-30 11:53:20 UTC) #1

dave_cheney.net

LGTM. This is virtually identical to the other change in crypto/sha512 Before: lucky(~/go/src/pkg/crypto/sha1) % cover ...

11 years, 6 months ago (2013-12-31 12:12:50 UTC) #2

dave_cheney.net

11 years, 6 months ago (2013-12-31 12:13:20 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5cbae677dac9 ***

crypto/sha1: add tests for Size() and BlockSize()

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/46400044

Committer: Dave Cheney <dave@cheney.net>

Expand All Messages | Collapse All Messages