Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1003)

Issue 4589049: code review 4589049: os/user: group lookup functions

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by andre
Modified:
8 years, 9 months ago
Reviewers:
akumar, r, brainman, rsc, bradfitz
CC:
golang-codereviews
Visibility:
Public.

Description

os/user: group lookup functions Adding group lookup functions analogous to the user lookup ones to the os/user package.

Patch Set 1 #

Patch Set 2 : diff -r 164ef168486b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 164ef168486b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 53460e066c2f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 0648704168fb https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r ecb31be11487 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 7 : diff -r 17e26defe7bc https://go.googlecode.com/hg/ #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -46 lines) Patch
M src/pkg/os/user/lookup_stubs.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/os/user/lookup_unix.go View 1 2 3 4 5 6 2 chunks +242 lines, -46 lines 1 comment Download
M src/pkg/os/user/user.go View 1 2 3 4 5 6 2 chunks +22 lines, -0 lines 1 comment Download
M src/pkg/os/user/user_test.go View 1 2 3 4 5 6 1 chunk +48 lines, -0 lines 1 comment Download

Messages

Total messages: 30
andre
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2011-06-12 06:13:52 UTC) #1
bradfitz
http://codereview.appspot.com/4589049/diff/4001/src/pkg/os/user/user.go File src/pkg/os/user/user.go (right): http://codereview.appspot.com/4589049/diff/4001/src/pkg/os/user/user.go#newcode24 src/pkg/os/user/user.go:24: Members []string I think Members should probably a method ...
11 years, 5 months ago (2011-06-13 16:46:37 UTC) #2
andre
On 2011/06/13 16:46:37, bradfitz wrote: > I think Members should probably a method on *Group, ...
11 years, 5 months ago (2011-06-13 20:29:46 UTC) #3
rsc
Shouldn't there be a 'is this user in this group' function? 99% of the time ...
11 years, 5 months ago (2011-06-14 15:38:54 UTC) #4
andre
On 2011/06/14 15:38:54, rsc wrote: > Shouldn't there be a 'is this user in this ...
11 years, 5 months ago (2011-06-14 17:09:18 UTC) #5
rsc
On Tue, Jun 14, 2011 at 13:09, <andrenth@gmail.com> wrote: > On 2011/06/14 15:38:54, rsc wrote: ...
11 years, 5 months ago (2011-06-14 17:14:46 UTC) #6
andre
On 2011/06/14 17:14:46, rsc wrote: > func (u *User) In(g *Group) (bool, os.Error) > > ...
11 years, 5 months ago (2011-06-14 17:32:21 UTC) #7
rsc
On Tue, Jun 14, 2011 at 13:32, <andrenth@gmail.com> wrote: > On 2011/06/14 17:14:46, rsc wrote: ...
11 years, 5 months ago (2011-06-14 17:34:07 UTC) #8
bradfitz
On Tue, Jun 14, 2011 at 10:32 AM, <andrenth@gmail.com> wrote: > On 2011/06/14 17:14:46, rsc ...
11 years, 5 months ago (2011-06-14 18:02:08 UTC) #9
andre
On 2011/06/14 18:02:08, bradfitz wrote: > getgroups? This returns a list of groups for the ...
11 years, 5 months ago (2011-06-14 18:10:30 UTC) #10
andre
On 2011/06/14 17:34:07, rsc wrote: > That's fine as long as it is in the ...
11 years, 5 months ago (2011-06-14 18:11:18 UTC) #11
rsc
>> getgrouplist? > > This returns a list of groups, so I don't think there's ...
11 years, 5 months ago (2011-06-14 18:12:34 UTC) #12
andre
On 2011/06/14 18:12:34, rsc wrote: > There is if the number of groups the user ...
11 years, 5 months ago (2011-06-14 20:35:55 UTC) #13
rsc
> The getgrouplist() function has to scan the member list of every group > to ...
11 years, 5 months ago (2011-06-14 20:42:12 UTC) #14
andre
New patch set uploaded.
11 years, 5 months ago (2011-06-14 20:54:16 UTC) #15
andre
By the way, the User type defines Uid and Gid as ints (I did the ...
11 years, 5 months ago (2011-06-16 12:53:08 UTC) #16
bradfitz
Sorry for the slow review. http://codereview.appspot.com/4589049/diff/11006/src/pkg/os/user/lookup_unix.go File src/pkg/os/user/lookup_unix.go (right): http://codereview.appspot.com/4589049/diff/11006/src/pkg/os/user/lookup_unix.go#newcode70 src/pkg/os/user/lookup_unix.go:70: nameC := C.CString(u.Username) think ...
11 years, 5 months ago (2011-06-22 18:33:08 UTC) #17
andre
Hi On 2011/06/22 18:33:08, bradfitz wrote: > think you're missing a free here > all ...
11 years, 5 months ago (2011-06-22 20:46:09 UTC) #18
russross
The Linux implementation here requires two calls to getgrgid_r to retrieve a list of group ...
11 years, 5 months ago (2011-07-08 17:31:29 UTC) #19
andre
On Fri, Jul 8, 2011 at 2:31 PM, <russross@gmail.com> wrote: > The Linux implementation here ...
11 years, 5 months ago (2011-07-09 03:23:47 UTC) #20
rsc
10 years, 6 months ago (2012-06-03 04:52:13 UTC) #21
akumar
Hi, what's the status of this? Was this dropped for some reason? Are there other ...
9 years, 9 months ago (2013-02-28 22:01:51 UTC) #22
bradfitz
I think it was simply forgotten. Alex, any comments on its interface? Is it too ...
9 years, 9 months ago (2013-03-01 00:34:33 UTC) #23
brainman
On 2013/03/01 00:34:33, bradfitz wrote: > > Alex, any comments on its interface? Is it ...
9 years, 9 months ago (2013-03-01 00:54:33 UTC) #24
r
Is this going anywhere?
9 years, 3 months ago (2013-08-29 01:09:26 UTC) #25
andre
On 2013/08/29 01:09:26, r wrote: > Is this going anywhere? If you guys need it, ...
9 years, 3 months ago (2013-08-29 11:25:41 UTC) #26
r
If you'd like to do that, please do. -rob
9 years, 3 months ago (2013-08-29 13:06:59 UTC) #27
andre
On 2013/08/29 13:06:59, r wrote: > If you'd like to do that, please do. Rob, ...
9 years, 3 months ago (2013-08-31 23:40:24 UTC) #28
gobot
Replacing golang-dev with golang-codereviews.
8 years, 11 months ago (2013-12-20 16:26:15 UTC) #29
rsc
8 years, 9 months ago (2014-03-05 20:06:37 UTC) #30
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b