Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(830)

Issue 13454043: os/user: group lookup functions

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 3 months ago by andre
Modified:
8 years, 5 months ago
Visibility:
Public.

Description

os/user: group lookup functions Adding group lookup functions analogous to the user lookup ones to the os/user package. Updates issue 4589049.

Patch Set 1 #

Patch Set 2 : diff -r 2aef8fd83bbd https://code.google.com/p/go #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -22 lines) Patch
M src/pkg/os/user/lookup.go View 1 1 chunk +29 lines, -2 lines 2 comments Download
M src/pkg/os/user/lookup_stubs.go View 1 1 chunk +10 lines, -2 lines 0 comments Download
M src/pkg/os/user/lookup_unix.go View 1 2 chunks +182 lines, -18 lines 0 comments Download
M src/pkg/os/user/user.go View 1 2 chunks +22 lines, -0 lines 2 comments Download
M src/pkg/os/user/user_test.go View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Still interested in finishing this? We can do it in Go 1.3. The CL text ...
8 years, 10 months ago (2014-01-16 18:43:35 UTC) #1
brainman
8 years, 10 months ago (2014-01-17 03:24:43 UTC) #2
hblanks.lf
All, It seems like this patch is a few minor edits from making it in. ...
8 years, 5 months ago (2014-06-15 05:51:33 UTC) #3
andre
8 years, 5 months ago (2014-06-16 18:35:45 UTC) #4
On 2014/06/15 05:51:33, hblanks.lf wrote:
> All,
> 
> It seems like this patch is a few minor edits from making it in. Andre, are
you
> still up for finishing it? This would be a good feature to have.
> 
> I'm not the best person to finish it, both for limited experience and time.
But,
> if you're indisposed, please let me know. I could try to sort out these last
> bits of review from Brad.
> 
> -HJB

Hi

I've created a new issue with a current version of the patch:
https://codereview.appspot.com/101310044
Probably did something wrong and couldn't edit this one with a new version...

The version in the new patch doesn't include (*Group) Members() as per Brad's
comment.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b