Blender COLLADA patch for optional export of selected and modified elements

With this patch the user has the option to export the mesh with all virtual, non applied modifers, and only the currently selected elements.

See also Issue 4387052, where this patch is based on.

[official.address243, 2011-05-02 22:43:48]

Correct Path now?

[official.address243, 2011-05-02 22:47:42]

3rd Version

[jesterKing, 2011-05-02 22:51:52]

On 2011/05/02 22:43:48, official.address243 wrote:
> Correct Path now?

This actually seems to be the correct patch set (nr 2).

[official.address243, 2011-05-04 16:31:51]

I've got over 1 billion faces, layers and whatever in "face_data".
And therefore I get of course an illegal access exception.
I examined the exporter and sadly it seems to be just a bug in the original
Blender code, not the COLLADA exporter code.

It happens on a 5k poly model I made in Blender 2.49. It's not that complex: ca.
5k polys, 60 bones, 1 material. A few bone animation keys. Nothing special.

Any idea what causes this?

========= Source ===================
	// writes <source> for normal coords
	createNormalsSource(geom_id, nor);

	CustomData *face_data = static_cast<CustomData *>(dm->getFaceDataArray(dm,
CD_MTFACE));
// =========== Following line causes a crash !!! ================
	bool has_uvs = face_data && static_cast<bool>(CustomData_has_layer(face_data,
CD_MTFACE));
// ==============================================================

	// writes <source> for uv coords if mesh has uv coords
	if (has_uvs)
		createTexcoordsSource(geom_id, dm);
=====================================

[official.address243, 2011-05-04 21:58:23]

Fixed crash on exporting complex data. Caused by false casting
(dm->getFaceDataArray to CustomData*)

[official.address243, 2011-05-04 22:00:12]

On 2011/05/04 21:58:23, official.address243 wrote:
> Fixed crash on exporting complex data. Caused by false casting
> (dm->getFaceDataArray to CustomData*)

Look at brechtvl's last comment at: http://codereview.appspot.com/4387052/.

[official.address243, 2011-05-04 22:02:07]

Now the normals are all wrong: Exports are flat without anything smoothed left.
Look at: GeometryExporter.cpp / GeometryExporter::getNormal. I think the bug is
there. But I don't get where the problem is.

[pjoe, 2011-05-27 20:01:02]

Added updated patch fixing the issue with normals in: #4530081

[pjoe, 2011-05-27 20:02:31]

On 2011/05/27 20:01:02, pjoe wrote:
> Added updated patch fixing the issue with normals in: #4530081

http://codereview.appspot.com/4530081/

[jesterKing, 2011-07-04 19:33:17]

On 2011/05/27 20:02:31, pjoe wrote:
> On 2011/05/27 20:01:02, pjoe wrote:
> > Added updated patch fixing the issue with normals in: #4530081
> 
> http://codereview.appspot.com/4530081/

This patch could now be closed, as export selection has been committed to trunk.