Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 4530081: Fix normals for Issue 4425084: Blender COLLADA patch for optional export of selected and modified el

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by pjoe
Modified:
9 years, 7 months ago
Reviewers:
jesterKing
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Based on http://codereview.appspot.com/4425084/. Fixed the issue with normals being exported incorrectly. Had to change BLENDER_CONFIG > BLENDER_USER_CONFIG to get the original patch compiling against r36947

Patch Set 1 #

Patch Set 2 : Updated against 37203 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -201 lines) Patch
source/blender/blenkernel/BKE_DerivedMesh.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
source/blender/blenkernel/BKE_cdderivedmesh.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
source/blender/blenlib/BLI_path_util.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/collada/ArmatureExporter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/collada/ArmatureExporter.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
source/blender/collada/CameraExporter.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/CameraExporter.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
source/blender/collada/DocumentExporter.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/DocumentExporter.cpp View 1 7 chunks +17 lines, -13 lines 0 comments Download
source/blender/collada/DocumentImporter.cpp View 1 1 chunk +111 lines, -0 lines 0 comments Download
source/blender/collada/EffectExporter.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/EffectExporter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/collada/GeometryExporter.h View 1 2 chunks +32 lines, -23 lines 0 comments Download
source/blender/collada/GeometryExporter.cpp View 1 12 chunks +167 lines, -120 lines 0 comments Download
source/blender/collada/ImageExporter.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/ImageExporter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/collada/LightExporter.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/LightExporter.cpp View 1 3 chunks +7 lines, -5 lines 0 comments Download
source/blender/collada/MaterialExporter.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
source/blender/collada/MaterialExporter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/collada/collada.h View 1 1 chunk +1 line, -1 line 0 comments Download
source/blender/collada/collada.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
source/blender/makesrna/intern/rna_scene_api.c View 1 2 chunks +6 lines, -3 lines 0 comments Download
source/blender/windowmanager/intern/wm_files.c View 1 3 chunks +54 lines, -2 lines 0 comments Download
source/blender/windowmanager/intern/wm_operators.c View 1 5 chunks +27 lines, -6 lines 0 comments Download
source/blender/windowmanager/wm_files.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
pjoe
12 years, 11 months ago (2011-05-27 19:58:21 UTC) #1
pjoe
Did some more testing: * Subdivided Suzanne ~8K faces * Deformed with lattice * Exported ...
12 years, 11 months ago (2011-05-28 09:11:59 UTC) #2
jesterKing
Quick reply so message gets sent to bf-coderview too.
12 years, 11 months ago (2011-05-31 12:13:01 UTC) #3
pjoe
Updated against 37203
12 years, 10 months ago (2011-06-05 10:26:45 UTC) #4
pjoe
12 years, 10 months ago (2011-06-13 08:33:38 UTC) #5
After doing some simple tests with skinned meshes, I've noticed an issue when
exporting with modifiers:

DerivedMesh will deform the actual mesh data according to the armature modifier.
On top of this a collada skin controller is also exported. This means that if
you are not in bind pose when exporting things will get screwed up, as the
armature deform is present both in mesh data and skin controller.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b