Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 4306055: New production module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by ced
Modified:
7 years, 11 months ago
Reviewers:
bch, albertnan, yangoon, nicoe, udono
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add bom tree with quantity computation #

Patch Set 3 : Add recursion check #

Patch Set 4 : Fix quantity digits of bom tree init #

Patch Set 5 : Update to trunk and add tests #

Total comments: 4

Patch Set 6 : Update to tip and fix comments #

Total comments: 3

Patch Set 7 : Add production Model (without workflow) #

Patch Set 8 : Fix order of import #

Patch Set 9 : Fix XML loading order #

Patch Set 10 : Remove nested views #

Patch Set 11 : Typo #

Patch Set 12 : Update to tip and add workflow #

Patch Set 13 : Add cost management #

Patch Set 14 : Add scenario and doc #

Total comments: 19

Patch Set 15 : Fix mathias comments #

Total comments: 14

Patch Set 16 : Fix get_uom_category when no product on production #

Patch Set 17 : Fix unit_digits if no uom #

Total comments: 2

Patch Set 18 : Fix typo in on_change_with_cost #

Patch Set 19 : Improve on_change_with_cost for empty lines #

Patch Set 20 : To be sure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3070 lines, -0 lines) Patch
A COPYRIGHT View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +32 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +11 lines, -0 lines 0 comments Download
A README View 1 chunk +36 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +8 lines, -0 lines 0 comments Download
A __tryton__.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +29 lines, -0 lines 0 comments Download
A bom.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +289 lines, -0 lines 0 comments Download
A bom.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +240 lines, -0 lines 0 comments Download
A configuration.py View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download
A configuration.xml View 1 2 3 4 5 6 1 chunk +43 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +63 lines, -0 lines 0 comments Download
A product.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +70 lines, -0 lines 0 comments Download
A product.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +67 lines, -0 lines 0 comments Download
A production.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +680 lines, -0 lines 0 comments Download
A production.xml View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +397 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +69 lines, -0 lines 0 comments Download
A stock.py View 1 2 3 4 5 6 1 chunk +36 lines, -0 lines 0 comments Download
A stock.xml View 1 2 3 4 5 6 1 chunk +48 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A tests/scenario_production.rst View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +177 lines, -0 lines 0 comments Download
A tests/test_production.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 56
ced
9 years ago (2011-03-26 16:28:27 UTC) #1
yangoon
9 years ago (2011-03-26 19:01:39 UTC) #2
udono
The module looks good. * I miss a view, which shows the BOM setup of ...
9 years ago (2011-03-29 07:58:52 UTC) #3
ced
On 2011/03/29 07:58:52, udono wrote: > The module looks good. > > * I miss ...
9 years ago (2011-04-03 13:20:35 UTC) #4
ced
8 years, 10 months ago (2011-05-15 19:57:07 UTC) #5
ced
8 years, 10 months ago (2011-05-16 18:38:43 UTC) #6
ced
8 years, 10 months ago (2011-05-16 18:47:07 UTC) #7
ced
8 years, 6 months ago (2011-09-20 12:47:39 UTC) #8
udono
https://codereview.appspot.com/4306055/diff/35001/bom.py File bom.py (right): https://codereview.appspot.com/4306055/diff/35001/bom.py#newcode33 bom.py:33: return quantity / output.quantity Missing copy method. It is ...
8 years, 5 months ago (2011-10-15 16:44:45 UTC) #9
ced
https://codereview.appspot.com/4306055/diff/35001/bom.py File bom.py (right): https://codereview.appspot.com/4306055/diff/35001/bom.py#newcode33 bom.py:33: return quantity / output.quantity On 2011/10/15 16:44:45, udono wrote: ...
8 years, 4 months ago (2011-11-14 10:29:38 UTC) #10
ced
8 years, 4 months ago (2011-11-14 16:35:51 UTC) #11
udono
https://codereview.appspot.com/4306055/diff/52001/bom.xml File bom.xml (right): https://codereview.appspot.com/4306055/diff/52001/bom.xml#newcode225 bom.xml:225: <record model="ir.action.wizard" id="wizard_bom_tree_open"> This wizard is no longer working ...
8 years, 4 months ago (2011-12-07 01:33:40 UTC) #12
udono
https://codereview.appspot.com/4306055/diff/52001/bom.xml File bom.xml (right): https://codereview.appspot.com/4306055/diff/52001/bom.xml#newcode225 bom.xml:225: <record model="ir.action.wizard" id="wizard_bom_tree_open"> No error message in client and ...
8 years, 4 months ago (2011-12-07 01:55:18 UTC) #13
udono
On 2011/12/07 01:55:18, udono wrote: > https://codereview.appspot.com/4306055/diff/52001/bom.xml > File bom.xml (right): > > https://codereview.appspot.com/4306055/diff/52001/bom.xml#newcode225 > ...
8 years, 4 months ago (2011-12-07 10:56:25 UTC) #14
ced
https://codereview.appspot.com/4306055/diff/52001/bom.xml File bom.xml (right): https://codereview.appspot.com/4306055/diff/52001/bom.xml#newcode225 bom.xml:225: <record model="ir.action.wizard" id="wizard_bom_tree_open"> On 2011/12/07 01:33:41, udono wrote: > ...
8 years, 4 months ago (2011-12-07 10:56:54 UTC) #15
udono
On 2011/12/07 10:56:54, ced wrote: > https://codereview.appspot.com/4306055/diff/52001/bom.xml > File bom.xml (right): > > https://codereview.appspot.com/4306055/diff/52001/bom.xml#newcode225 > ...
8 years, 4 months ago (2011-12-07 11:09:10 UTC) #16
udono
On 2011/12/07 11:09:10, udono wrote: > On 2011/12/07 10:56:54, ced wrote: > > https://codereview.appspot.com/4306055/diff/52001/bom.xml > ...
8 years, 4 months ago (2011-12-07 11:35:34 UTC) #17
udono
On 2011/12/07 11:35:34, udono wrote: > On 2011/12/07 11:09:10, udono wrote: > > On 2011/12/07 ...
8 years, 4 months ago (2011-12-07 11:41:35 UTC) #18
bch
On 2011/04/03 13:20:35, ced wrote: > On 2011/03/29 07:58:52, udono wrote: > > * Why ...
8 years, 3 months ago (2011-12-20 13:32:06 UTC) #19
ced
On 20/12/11 13:32 +0000, bertrand.chenal@b2ck.com wrote: > On 2011/04/03 13:20:35, ced wrote: > >On 2011/03/29 ...
8 years, 1 month ago (2012-02-14 09:16:58 UTC) #20
ced
8 years, 1 month ago (2012-02-15 15:02:56 UTC) #21
albertnan
On 2012/02/15 15:02:56, ced wrote: LGTM
8 years, 1 month ago (2012-02-22 07:50:51 UTC) #22
ced
8 years, 1 month ago (2012-03-01 21:39:08 UTC) #23
ced
8 years, 1 month ago (2012-03-01 21:47:11 UTC) #24
ced
8 years, 1 month ago (2012-03-02 09:41:04 UTC) #25
ced
8 years, 1 month ago (2012-03-05 08:47:08 UTC) #26
ced
8 years ago (2012-03-17 20:43:35 UTC) #27
ced
8 years ago (2012-04-01 13:48:06 UTC) #28
ced
8 years ago (2012-04-06 23:55:57 UTC) #29
yangoon
Only superficial review, untested http://codereview.appspot.com/4306055/diff/117002/INSTALL File INSTALL (right): http://codereview.appspot.com/4306055/diff/117002/INSTALL#newcode10 INSTALL:10: * trytond_stock (http://www.tryton.org/) company missing ...
8 years ago (2012-04-07 12:48:04 UTC) #30
ced
8 years ago (2012-04-07 19:00:33 UTC) #31
ced
https://codereview.appspot.com/4306055/diff/117002/bom.py File bom.py (right): https://codereview.appspot.com/4306055/diff/117002/bom.py#newcode60 bom.py:60: 'product.uom.category', 'Uom Category', On 2012/04/07 12:48:04, yangoon wrote: > ...
8 years ago (2012-04-07 19:00:48 UTC) #32
yangoon
https://codereview.appspot.com/4306055/diff/117002/bom.py File bom.py (right): https://codereview.appspot.com/4306055/diff/117002/bom.py#newcode60 bom.py:60: 'product.uom.category', 'Uom Category', On 2012/04/07 19:00:49, ced wrote: > ...
8 years ago (2012-04-08 09:18:42 UTC) #33
udono
http://codereview.appspot.com/4306055/diff/119006/stock.xml File stock.xml (right): http://codereview.appspot.com/4306055/diff/119006/stock.xml#newcode35 stock.xml:35: When try to install the module, with the next ...
7 years, 12 months ago (2012-04-12 05:29:08 UTC) #34
ced
https://codereview.appspot.com/4306055/diff/119006/stock.xml File stock.xml (right): https://codereview.appspot.com/4306055/diff/119006/stock.xml#newcode35 stock.xml:35: On 2012/04/12 05:29:08, udono wrote: > When try to ...
7 years, 12 months ago (2012-04-12 08:48:47 UTC) #35
udono
https://codereview.appspot.com/4306055/diff/119006/stock.xml File stock.xml (right): https://codereview.appspot.com/4306055/diff/119006/stock.xml#newcode35 stock.xml:35: On 2012/04/12 08:48:47, ced wrote: > I can not ...
7 years, 12 months ago (2012-04-13 07:38:11 UTC) #36
udono
https://codereview.appspot.com/4306055/diff/119006/__tryton__.py File __tryton__.py (right): https://codereview.appspot.com/4306055/diff/119006/__tryton__.py#newcode5 __tryton__.py:5: 'version': '0.0.1', Don't forget to fix version to 2.4.0 ...
7 years, 12 months ago (2012-04-13 08:29:32 UTC) #37
ced
https://codereview.appspot.com/4306055/diff/119006/bom.py File bom.py (right): https://codereview.appspot.com/4306055/diff/119006/bom.py#newcode20 bom.py:20: 'bom', 'product', 'Output Products') On 2012/04/13 08:29:33, udono wrote: ...
7 years, 12 months ago (2012-04-13 09:12:16 UTC) #38
udono
Save a production, after fill all required fields, the following error raises: Traceback (most recent ...
7 years, 12 months ago (2012-04-13 10:13:10 UTC) #39
ced
7 years, 12 months ago (2012-04-13 11:04:46 UTC) #40
udono
On 2012/04/13 10:13:10, udono wrote: > Save a production, after fill all required fields, the ...
7 years, 12 months ago (2012-04-13 13:46:58 UTC) #41
ced
7 years, 12 months ago (2012-04-13 13:59:00 UTC) #42
udono
https://codereview.appspot.com/4306055/diff/119006/production.py File production.py (right): https://codereview.appspot.com/4306055/diff/119006/production.py#newcode139 production.py:139: 'missing_cost': 'It misses some cost on the outputs!', On ...
7 years, 12 months ago (2012-04-13 14:39:17 UTC) #43
udono
https://codereview.appspot.com/4306055/diff/129004/production.py File production.py (right): https://codereview.appspot.com/4306055/diff/129004/production.py#newcode120 production.py:120: | ~Eval('location')), I checked this states with a production ...
7 years, 12 months ago (2012-04-13 15:53:11 UTC) #44
ced
https://codereview.appspot.com/4306055/diff/129004/production.py File production.py (right): https://codereview.appspot.com/4306055/diff/129004/production.py#newcode120 production.py:120: | ~Eval('location')), On 2012/04/13 15:53:11, udono wrote: > I ...
7 years, 12 months ago (2012-04-13 16:19:26 UTC) #45
ced
7 years, 12 months ago (2012-04-13 16:29:22 UTC) #46
udono
On 2012/04/13 16:19:26, ced wrote: > https://codereview.appspot.com/4306055/diff/129004/production.py > File production.py (right): > > https://codereview.appspot.com/4306055/diff/129004/production.py#newcode120 > ...
7 years, 12 months ago (2012-04-13 16:33:06 UTC) #47
ced
7 years, 12 months ago (2012-04-13 16:39:24 UTC) #48
ced
https://codereview.appspot.com/4306055/diff/119006/production.py File production.py (right): https://codereview.appspot.com/4306055/diff/119006/production.py#newcode139 production.py:139: 'missing_cost': 'It misses some cost on the outputs!', On ...
7 years, 12 months ago (2012-04-13 16:47:36 UTC) #49
udono
On 2012/04/13 16:47:36, ced wrote: > https://codereview.appspot.com/4306055/diff/119006/production.py > File production.py (right): > > https://codereview.appspot.com/4306055/diff/119006/production.py#newcode139 > ...
7 years, 11 months ago (2012-04-18 18:15:36 UTC) #50
udono
I better clarify the scenario and point to the problems. This steps works as expected ...
7 years, 11 months ago (2012-04-20 14:28:07 UTC) #51
ced
On 20/04/12 14:28 +0000, udo.spallek@googlemail.com wrote: > I better clarify the scenario and point to ...
7 years, 11 months ago (2012-04-27 17:56:26 UTC) #52
ced
7 years, 11 months ago (2012-04-27 19:57:27 UTC) #53
udono
LGTM On 2012/04/27 17:56:26, ced wrote: > On 20/04/12 14:28 +0000, mailto:udo.spallek@googlemail.com wrote: > > ...
7 years, 11 months ago (2012-04-30 15:49:12 UTC) #54
ced
On 30/04/12 15:49 +0000, udo.spallek@googlemail.com wrote: > >> > * Workflow: Wait, assign, force assign, ...
7 years, 11 months ago (2012-04-30 16:02:02 UTC) #55
udono
7 years, 11 months ago (2012-04-30 16:41:38 UTC) #56
On 2012/04/30 16:02:02, ced wrote:
> On 30/04/12 15:49 +0000, mailto:udo.spallek@googlemail.com wrote:
> > >> >      * Workflow: Wait, assign, force assign, run
> > >> >      * When hitting done: It misses some cost on the outputs!
> > >Have you set the unit price of the outgoing move correctly?
> > >It must match the cost.
> > Yes, this works. So why not make it a function field and fill it with
> > the
> > cost / qty?
> It can not be a function field because it is a choice to be made by
> users.
> By default, if you use a BOM than we know what is the target product and
> the unit price is filled with the cost price.
Thanks for clarification, now I understand. In the on-the-fly setup of the
production (without BOM) we can have more than one Output Line. So we can not
know the unit price for each line.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b