Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3122)

Issue 40510046: Web: Download: Add introductory text

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by uliska
Modified:
10 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Web: Download: Add introductory text This addresses the initial issue discussed on lilypond-user: too many people don't understand what they download and get stuck on not being able to "open the LilyPond program". Add a text that explains the compiled approach and makes clear one should have LilyPond _and_ an editing environment. The current warning (which apparently wasn't sufficient) has been removed from this page but is kept on the subpages in case someone reaches them by a direct link.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Incorporate comments #

Total comments: 16

Patch Set 3 : Incorporating review comments #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M Documentation/web/download.itexi View 1 2 1 chunk +30 lines, -2 lines 4 comments Download

Messages

Total messages: 26
uliska
10 years, 4 months ago (2013-12-12 12:44:49 UTC) #1
Trevor Daniels
A couple of nitpicks, otherwise LGTM. https://codereview.appspot.com/40510046/diff/1/Documentation/web/download.itexi File Documentation/web/download.itexi (right): https://codereview.appspot.com/40510046/diff/1/Documentation/web/download.itexi#newcode57 Documentation/web/download.itexi:57: concept you'll find ...
10 years, 4 months ago (2013-12-12 17:40:44 UTC) #2
uliska
Incorporate comments
10 years, 4 months ago (2013-12-12 18:47:33 UTC) #3
pkx166h
Overall this is a bit too chatty for my liking. I have tried to give ...
10 years, 4 months ago (2013-12-13 06:00:09 UTC) #4
uliska
Incorporated most of the comments. Will upload new patch set in a minute https://codereview.appspot.com/40510046/diff/20001/Documentation/web/download.itexi File ...
10 years, 4 months ago (2013-12-13 10:59:33 UTC) #5
uliska
Incorporating review comments
10 years, 4 months ago (2013-12-13 11:00:36 UTC) #6
Graham Percival
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi File Documentation/web/download.itexi (left): https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi#oldcode35 Documentation/web/download.itexi:35: @warningTextBased Umm, isn't the whole point of this to ...
10 years, 4 months ago (2013-12-14 03:51:33 UTC) #7
uliska
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi File Documentation/web/download.itexi (left): https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi#oldcode35 Documentation/web/download.itexi:35: @warningTextBased On 2013/12/14 03:51:33, Graham Percival wrote: > Umm, ...
10 years, 4 months ago (2013-12-14 09:46:53 UTC) #8
Graham Percival
On Sat, Dec 14, 2013 at 09:46:54AM +0000, lilyliska@googlemail.com wrote: > > On 2013/12/14 03:51:33, ...
10 years, 4 months ago (2013-12-15 05:47:12 UTC) #9
ul_openlilylib.org
Am 15.12.2013 06:47, schrieb Graham Percival: > On Sat, Dec 14, 2013 at 09:46:54AM +0000, ...
10 years, 4 months ago (2013-12-15 12:23:52 UTC) #10
pkx166h
Urs, On 15/12/13 12:23, Urs Liska wrote: > > > I'm worried about the opposition ...
10 years, 4 months ago (2013-12-15 13:14:06 UTC) #11
ul_openlilylib.org
Am 15.12.2013 14:14, schrieb James: > Urs, > > On 15/12/13 12:23, Urs Liska wrote: ...
10 years, 4 months ago (2013-12-15 15:15:28 UTC) #12
dak
Urs Liska <ul@openlilylib.org> writes: > I know that and I fully agree that it's important ...
10 years, 4 months ago (2013-12-15 18:48:31 UTC) #13
Graham Percival
On Sun, Dec 15, 2013 at 07:48:28PM +0100, David Kastrup wrote: > Urs Liska <ul@openlilylib.org> ...
10 years, 4 months ago (2013-12-16 03:30:02 UTC) #14
Graham Percival
On Mon, Dec 16, 2013 at 11:29:44AM +0800, Graham Percival wrote: > > Urs Liska ...
10 years, 4 months ago (2013-12-16 03:32:01 UTC) #15
Graham Percival
On Sun, Dec 15, 2013 at 01:23:51PM +0100, Urs Liska wrote: > Am 15.12.2013 06:47, ...
10 years, 4 months ago (2013-12-16 05:16:01 UTC) #16
Carl P.
On Dec 16, 2013 12:16 AM, "Graham Percival" <graham@percival-music.ca> wrote: > > On Sun, Dec ...
10 years, 4 months ago (2013-12-16 05:42:16 UTC) #17
Graham Percival
On Mon, Dec 16, 2013 at 12:42:16AM -0500, Carl Peterson wrote: > Just thinking out ...
10 years, 4 months ago (2013-12-16 07:57:04 UTC) #18
ul_openlilylib.org
Am 16.12.2013 04:31, schrieb Graham Percival: > On Mon, Dec 16, 2013 at 11:29:44AM +0800, ...
10 years, 4 months ago (2013-12-16 10:09:45 UTC) #19
dak
Carl Peterson <carlopeterson@gmail.com> writes: > On Dec 16, 2013 12:16 AM, "Graham Percival" <graham@percival-music.ca> > ...
10 years, 4 months ago (2013-12-16 10:11:47 UTC) #20
ul_openlilylib.org
Am 15.12.2013 19:48, schrieb David Kastrup: > Urs Liska <ul@openlilylib.org> writes: > ... >> Viewed ...
10 years, 4 months ago (2013-12-16 10:24:55 UTC) #21
ul_openlilylib.org
Am 16.12.2013 04:29, schrieb Graham Percival: >>> I don't want to imagine what happens if ...
10 years, 4 months ago (2013-12-16 10:26:44 UTC) #22
ul_openlilylib.org
Am 16.12.2013 06:15, schrieb Graham Percival: > On Sun, Dec 15, 2013 at 01:23:51PM +0100, ...
10 years, 4 months ago (2013-12-16 11:14:03 UTC) #23
Carl P.
On Mon, Dec 16, 2013 at 4:25 AM, David Kastrup <dak@gnu.org> wrote: > Carl Peterson ...
10 years, 4 months ago (2013-12-16 18:50:54 UTC) #24
Graham Percival
On Mon, Dec 16, 2013 at 01:50:53PM -0500, Carl Peterson wrote: > (2) utilizing back-end ...
10 years, 4 months ago (2013-12-18 10:30:32 UTC) #25
Carl P.
10 years, 4 months ago (2013-12-18 13:22:08 UTC) #26
On Wed, Dec 18, 2013 at 5:30 AM, Graham Percival
<graham@percival-music.ca> wrote:
> On Mon, Dec 16, 2013 at 01:50:53PM -0500, Carl Peterson wrote:
>> (2) utilizing back-end scripting (PHP, etc.) to custom-serve the
>> content based on the http header.
>
> We're using a donated web-server, and don't have root access.
> When (not if) PHP has another security hole, I don't think we want
> us to be responsible for somebody else's server getting hosed.
>
Indeed, I meant this paragraph to indicate two generally undesirable
options for serving the content with the detected operating system
info on top and all the other information rearranged on the same page,
not as "this is what we should do."

Carl P.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b