Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 4124056: Doc: NR rewrite of 3.2 Titles and Headers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by pkx166h
Modified:
7 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR rewrite of 3.2 Titles and Headers This is an edited verion of Mark Polesky's patch http://codereview.appspot.com/3667041/ No new information has been added from the original patch, but the text has been edited so that it is more suitable to the Notation Reference Style.

Patch Set 1 #

Total comments: 20

Patch Set 2 : Second Draft #

Total comments: 25

Patch Set 3 : Third Draft of NR 3.2 Rewrite #

Patch Set 4 : 4th Draft with new papersize incorp'd #

Total comments: 11

Patch Set 5 : Draft 5 without ly/ file and minor spacing edits #

Patch Set 6 : 6th Draft #

Patch Set 7 : 7th draft #

Total comments: 17

Patch Set 8 : Draft 8 #

Patch Set 9 : Draft 9 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -213 lines) Patch
M Documentation/notation/input.itely View 1 2 3 4 5 6 7 8 3 chunks +414 lines, -213 lines 2 comments Download

Messages

Total messages: 26
Graham Percival (old account)
I've done a first pass at this. General comment: there's more "talking through the code" ...
8 years, 3 months ago (2011-02-06 03:21:32 UTC) #1
Jean-Charles
Le 06/02/2011 04:21, percival.music.ca@gmail.com disait : > [...] > Documentation/notation/input.itely:526: @subsection Creating titles, > headers, ...
8 years, 3 months ago (2011-02-06 13:27:48 UTC) #2
Trevor Daniels
This comment of mine from Mark's patch still applies, even after these changes: > I've ...
8 years, 3 months ago (2011-02-06 17:48:56 UTC) #3
Graham Percival (old account)
On 2011/02/06 17:48:56, Trevor Daniels wrote: > This comment of mine from Mark's patch still ...
8 years, 3 months ago (2011-02-06 20:41:40 UTC) #4
t.daniels_treda.co.uk
<percival.music.ca@gmail.com> wrote Sunday, February 06, 2011 8:41 PM > On 2011/02/06 17:48:56, Trevor Daniels wrote: ...
8 years, 3 months ago (2011-02-07 11:02:39 UTC) #5
James.Lowe_datacore.com
Hello, ________________________________________ From: lilypond-devel-bounces+james.lowe=datacore.com@gnu.org [lilypond-devel-bounces+james.lowe=datacore.com@gnu.org] on behalf of Trevor Daniels [t.daniels@treda.co.uk] Sent: 07 February 2011 ...
8 years, 3 months ago (2011-02-07 13:41:48 UTC) #6
Graham Percival
On Mon, Feb 07, 2011 at 11:02:16AM -0000, Trevor Daniels wrote: > > I think ...
8 years, 3 months ago (2011-02-07 13:46:46 UTC) #7
Graham Percival
On Mon, Feb 07, 2011 at 01:41:45PM +0000, James Lowe wrote: > Where my skill ...
8 years, 3 months ago (2011-02-07 14:06:48 UTC) #8
pkx166h
Second draft been posted. I couldn't work out how to do one request so this ...
8 years, 3 months ago (2011-02-13 17:03:22 UTC) #9
Graham Percival (old account)
Read Usage and play with lilypond-book a bit on your own. 1. I want you ...
8 years, 3 months ago (2011-02-15 01:28:04 UTC) #10
pkx166h
Third draft done - sorry it took so long. http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4124056/diff/9001/Documentation/notation/input.itely#newcode541 Documentation/notation/input.itely:541: ...
8 years, 2 months ago (2011-02-25 14:17:26 UTC) #11
pkx166h
4th Draft posted. Still to do: Showing how 'breakbefore' works, as it was evident from ...
8 years, 1 month ago (2011-04-09 20:19:30 UTC) #12
Mark Polesky
Thanks again to everyone here for helping to finish what I started. I'll leave the ...
8 years, 1 month ago (2011-04-09 21:34:26 UTC) #13
Graham Percival (old account)
http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4124056/diff/18001/Documentation/notation/input.itely#newcode548 Documentation/notation/input.itely:548: @lilypond[quote,verbatim,noragged-right,staffsize=17,indent=13\mm] I want a general rule for this stuff. ...
8 years, 1 month ago (2011-04-10 04:11:43 UTC) #14
pkx166h
5th Draft, nothing to really check (apart from Marks 3 spacing edits) but have removed ...
8 years, 1 month ago (2011-04-10 16:06:41 UTC) #15
pkx166h
Just an updated. New Patch for @lilypond policy here http://codereview.appspot.com/4445070/ Once we have ratified this ...
8 years ago (2011-04-27 16:31:15 UTC) #16
pkx166h
7th Draft up for review. Drafts 5 and 6 are not valid (one was just ...
8 years ago (2011-05-04 16:37:10 UTC) #17
Carl
Looks mostly good to me. Carl http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode667 Documentation/notation/input.itely:667: Text fields left ...
8 years ago (2011-05-04 17:08:39 UTC) #18
Graham Percival (old account)
comments about the first section. http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode674 Documentation/notation/input.itely:674: @example We just spent ...
8 years ago (2011-05-04 23:32:36 UTC) #19
pkx166h
Draft 8 http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode667 Documentation/notation/input.itely:667: Text fields left unset in a @code{\header} ...
8 years ago (2011-05-05 11:05:22 UTC) #20
Graham Percival (old account)
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode674 Documentation/notation/input.itely:674: @example On 2011/05/05 11:05:22, J_lowe wrote: > Yes we ...
8 years ago (2011-05-05 23:06:25 UTC) #21
pkx166h
On 2011/05/05 23:06:25, Graham Percival wrote: > http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely > File Documentation/notation/input.itely (right): > > http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode674 ...
8 years ago (2011-05-19 16:55:49 UTC) #22
lemniskata.bernoulliego
LGTM 2011/5/19 <pkx166h@gmail.com> > On 2011/05/05 23:06:25, Graham Percival wrote: > > > http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely > ...
7 years, 12 months ago (2011-05-23 10:30:48 UTC) #23
Graham Percival (old account)
It's not perfect (I didn't comment on a few things), but it's now unquestionably better ...
7 years, 12 months ago (2011-05-25 10:25:46 UTC) #24
pkx166h
Pushed as 9bc65fa2efa4711ce96c648db6d703ae190f944c Graham, if you want to add your 'new' comments now here, I ...
7 years, 12 months ago (2011-05-25 12:46:03 UTC) #25
pkx166h
7 years, 11 months ago (2011-06-05 10:28:30 UTC) #26
On 2011/05/04 17:08:39, Carl wrote:
> Looks mostly good to me.
> 
> Carl
> 
>
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input...
> File Documentation/notation/input.itely (right):
> 
>
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input...
> Documentation/notation/input.itely:667: Text fields left unset in a
> @code{\header} block are replaced with
> This paragraph has three different ideas -- null markups, piece and opus, and
> forcing titles to start on a new page.
> 
> They should probably be separated into three different paragraphs.
> 
>
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input...
> Documentation/notation/input.itely:937: 
> Need @seealso for the @ref in this node -- Title blocks explained, Default
> layout of book and score title blocks,.
> 
>
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input...
> Documentation/notation/input.itely:987: @end lilypond
> Need @seealso here, with all of the @ref in this node (Default layout of book
> and title blocks).

Carl, I have done this now (and the one above). We only really focused on the
'first half' of the text that Mark did (and also hammer out all the @lilypond
settings too).

I am going to close this issue - I left it open only because I remembered you
wanted some additions that were not going to be in the main patch, and open a
new one with these and other changes. I also wanted to make some more 'edits' to
this text once the major changes were done to keep some layout and style
consistency.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b