code review 38330045: os: return ErrInvalid if receiver is nil.

os: return ErrInvalid if receiver is nil.

Fixes issue 7043.

Test coming in https://codereview.appspot.com/46820043

[dave_cheney.net, 2014-01-03 21:11:59]

Hello r@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-01-03 21:12:41]

LGTM



On Fri, Jan 3, 2014 at 1:12 PM, <dave@cheney.net> wrote:

> Reviewers: r,
>
> Message:
> Hello r@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> os: return ErrInvalid if receiver is nil.
>
> Fixes issue 7043.
>
> Test coming in https://codereview.appspot.com/46820043
>
> Please review this at https://codereview.appspot.com/38330045/
>
> Affected files (+1, -1 lines):
>   M src/pkg/os/file_posix.go
>
>
> Index: src/pkg/os/file_posix.go
> ===================================================================
> --- a/src/pkg/os/file_posix.go
> +++ b/src/pkg/os/file_posix.go
> @@ -144,7 +144,7 @@
>  // of recently written data to disk.
>  func (f *File) Sync() (err error) {
>         if f == nil {
> -               return syscall.EINVAL
> +               return ErrInvalid
>         }
>         if e := syscall.Fsync(f.fd); e != nil {
>                 return NewSyscallError("fsync", e)
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[r, 2014-01-03 21:20:25]

LGTM

[dave_cheney.net, 2014-01-03 21:25:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=ed6590528a11 ***

os: return ErrInvalid if receiver is nil.

Fixes issue 7043.

Test coming in https://codereview.appspot.com/46820043

R=r, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/38330045