code review 46820043: os: add tests for operations on nil *File methods

os: add tests for operations on nil *File methods

[dave_cheney.net, 2014-01-01 06:02:47]

Hello shawn.p.smith@gmail.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[shawnps, 2014-01-01 06:45:40]

On 2014/01/01 06:02:47, dfc wrote:
> Hello mailto:shawn.p.smith@gmail.com (cc:
mailto:golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

LGTM.

before:
PASS
coverage: 66.7% of statements
ok  	os	0.418s
os/doc.go:		Readdir		100.0%
os/doc.go:		Readdirnames	100.0%
os/file.go:			Read			70.0%
os/file.go:			ReadAt		76.9%
os/file.go:			Write			63.6%
os/file.go:			WriteAt		72.7%
os/file.go:			Seek			62.5%
os/file.go:			WriteString	66.7%
os/file.go:			Chdir		60.0%
os/file_posix.go:	Chmod		60.0%
os/file_posix.go:	Chown		60.0%
os/file_posix.go:	Truncate		60.0%
os/file_unix.go:	Close		66.7%
os/file_unix.go:	Stat			71.4%
total:			(statements)		66.7%

after:
PASS
coverage: 68.7% of statements
ok  	os	0.422s
os/doc.go:		Readdir		100.0%
os/doc.go:		Readdirnames	100.0%
os/file.go:			Read			80.0%
os/file.go:			ReadAt		84.6%
os/file.go:			Write			72.7%
os/file.go:			WriteAt		81.8%
os/file.go:			Seek			75.0%
os/file.go:			WriteString	100.0%
os/file.go:			Chdir		80.0%
os/file_posix.go:	Chmod		80.0%
os/file_posix.go:	Chown		80.0%
os/file_posix.go:	Truncate		80.0%
os/file_unix.go:	Close		100.0%
os/file_unix.go:	Stat			85.7%
total:			(statements)		68.7%

[dave_cheney.net, 2014-01-01 06:48:49]

Thanks, I'll wait to get a ruling on issue 7043 before proceeding. 

> On 1 Jan 2014, at 17:45, shawn.p.smith@gmail.com wrote:
> 
>> On 2014/01/01 06:02:47, dfc wrote:
>> Hello mailto:shawn.p.smith@gmail.com (cc:
> mailto:golang-codereviews@googlegroups.com),
> 
>> I'd like you to review this change to
>> https://code.google.com/p/go
> 
> LGTM.
> 
> before:
> PASS
> coverage: 66.7% of statements
> ok      os    0.418s
> os/doc.go:        Readdir        100.0%
> os/doc.go:        Readdirnames    100.0%
> os/file.go:            Read            70.0%
> os/file.go:            ReadAt        76.9%
> os/file.go:            Write            63.6%
> os/file.go:            WriteAt        72.7%
> os/file.go:            Seek            62.5%
> os/file.go:            WriteString    66.7%
> os/file.go:            Chdir        60.0%
> os/file_posix.go:    Chmod        60.0%
> os/file_posix.go:    Chown        60.0%
> os/file_posix.go:    Truncate        60.0%
> os/file_unix.go:    Close        66.7%
> os/file_unix.go:    Stat            71.4%
> total:            (statements)        66.7%
> 
> after:
> PASS
> coverage: 68.7% of statements
> ok      os    0.422s
> os/doc.go:        Readdir        100.0%
> os/doc.go:        Readdirnames    100.0%
> os/file.go:            Read            80.0%
> os/file.go:            ReadAt        84.6%
> os/file.go:            Write            72.7%
> os/file.go:            WriteAt        81.8%
> os/file.go:            Seek            75.0%
> os/file.go:            WriteString    100.0%
> os/file.go:            Chdir        80.0%
> os/file_posix.go:    Chmod        80.0%
> os/file_posix.go:    Chown        80.0%
> os/file_posix.go:    Truncate        80.0%
> os/file_unix.go:    Close        100.0%
> os/file_unix.go:    Stat            85.7%
> total:            (statements)        68.7%
> 
> https://codereview.appspot.com/46820043/

[gobot, 2014-01-03 18:26:07]

R=r@golang.org (assigned by r@golang.org)

[r, 2014-01-03 18:38:41]

https://codereview.appspot.com/46820043/diff/40001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

https://codereview.appspot.com/46820043/diff/40001/src/pkg/os/os_test.go#newc...
src/pkg/os/os_test.go:1317: func TestNilFileMethods(t *testing.T) {
// Test that all File methods give ErrInvalid if the receiver is nil.

[dave_cheney.net, 2014-01-03 21:12:33]

Done. PTAL

https://codereview.appspot.com/46820043/diff/40001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

https://codereview.appspot.com/46820043/diff/40001/src/pkg/os/os_test.go#newc...
src/pkg/os/os_test.go:1317: func TestNilFileMethods(t *testing.T) {
On 2014/01/03 18:38:42, r wrote:
> // Test that all File methods give ErrInvalid if the receiver is nil.

Done.

[dave_cheney.net, 2014-01-03 21:12:52]

Hello shawn.p.smith@gmail.com, gobot@golang.org, r@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[r, 2014-01-03 21:19:25]

https://codereview.appspot.com/46820043/diff/60001/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

https://codereview.appspot.com/46820043/diff/60001/src/pkg/os/os_test.go#newc...
src/pkg/os/os_test.go:1317: // Test that all File methods give ErrInvalid if the
receiver is nil.
please move this comment up one line, before the function signature..

[r, 2014-01-03 21:20:01]

LGTM after that

[dave_cheney.net, 2014-01-03 21:22:04]

On Sat, Jan 4, 2014 at 8:19 AM, <r@golang.org> wrote:

>
> https://codereview.appspot.com/46820043/diff/60001/src/pkg/os/os_test.go
> File src/pkg/os/os_test.go (right):
>
> https://codereview.appspot.com/46820043/diff/60001/src/
> pkg/os/os_test.go#newcode1317
> src/pkg/os/os_test.go:1317: // Test that all File methods give
>
> ErrInvalid if the receiver is nil.
> please move this comment up one line, before the function signature..
>

My mistake, will do.


>
> https://codereview.appspot.com/46820043/
>

[dave_cheney.net, 2014-01-03 22:58:22]

*** Submitted as https://code.google.com/p/go/source/detail?r=cc85f5964821 ***

os: add tests for operations on nil *File methods

R=shawn.p.smith, gobot, r
CC=golang-codereviews
https://codereview.appspot.com/46820043