Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 36020043: code review 36020043: os, os/exec, os/user: add support for GOOS=solaris

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by aram
Modified:
1 year, 3 months ago
Reviewers:
minux1, jsing
CC:
golang-codereviews, dfc, minux1, gobot, jsing
Visibility:
Public.

Description

os, os/exec, os/user: add support for GOOS=solaris

Patch Set 1 #

Patch Set 2 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 3 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 4 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 5 : diff -r bddf2a72f5e1 https://code.google.com/p/go #

Patch Set 6 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 7 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 8 : diff -r 6835745cc243 https://code.google.com/p/go #

Patch Set 9 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 10 : diff -r 17615253b9e8 https://code.google.com/p/go #

Total comments: 2

Patch Set 11 : diff -r 17615253b9e8 https://code.google.com/p/go #

Patch Set 12 : diff -r d45af824172f https://code.google.com/p/go #

Patch Set 13 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 14 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 15 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 16 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 17 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Patch Set 18 : diff -r 1e52bf0c539c https://code.google.com/p/go #

Total comments: 2

Patch Set 19 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 20 : diff -r 884801fb67af https://code.google.com/p/go #

Patch Set 21 : diff -r 884801fb67af https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M src/pkg/os/dir_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/env_unix_test.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/error_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec/exec_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/os/exec/lp_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec/lp_unix_test.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec_posix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/exec_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/file_posix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/file_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/os_unix_test.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/path_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/pipe_bsd.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/signal/signal_test.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/signal/signal_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/stat_solaris.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -2 lines 0 comments Download
A src/pkg/os/sys_solaris.go View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/os/user/lookup_unix.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17
aram
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
1 year, 4 months ago (2013-12-10 20:40:34 UTC) #1
dfc
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go#newcode7 src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong It's ...
1 year, 4 months ago (2013-12-10 23:45:17 UTC) #2
aram
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go#newcode7 src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong On ...
1 year, 4 months ago (2013-12-11 21:27:14 UTC) #3
minux1
LGTM.
1 year, 4 months ago (2013-12-13 07:08:02 UTC) #4
gobot
Replacing golang-dev with golang-codereviews.
1 year, 4 months ago (2013-12-20 16:26:20 UTC) #5
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
1 year, 4 months ago (2013-12-21 21:48:58 UTC) #6
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
1 year, 4 months ago (2013-12-29 17:45:19 UTC) #7
gobot
R=jsing@google.com (assigned by aram@mgk.ro)
1 year, 3 months ago (2014-01-07 23:20:11 UTC) #8
jsing
LGTM https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1 src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights ...
1 year, 3 months ago (2014-01-08 10:38:34 UTC) #9
dfc
> On 8 Jan 2014, at 21:38, jsing@google.com wrote: > > LGTM > > > ...
1 year, 3 months ago (2014-01-08 11:07:09 UTC) #10
jsing
On 2014/01/08 11:07:09, dfc wrote: > > > On 8 Jan 2014, at 21:38, mailto:jsing@google.com ...
1 year, 3 months ago (2014-01-08 11:30:13 UTC) #11
dfc
Sure. But I can cite many examples in the current code base that can support ...
1 year, 3 months ago (2014-01-08 11:33:04 UTC) #12
aram
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go File src/pkg/os/stat_solaris.go (right): https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1 src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights reserved. ...
1 year, 3 months ago (2014-01-09 15:09:16 UTC) #13
aram
1 year, 3 months ago (2014-01-09 15:09:17 UTC) #14
aram
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com, gobot@golang.org, jsing@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
1 year, 3 months ago (2014-01-09 15:11:02 UTC) #15
jsing
LGTM
1 year, 3 months ago (2014-01-09 15:48:13 UTC) #16
jsing
1 year, 3 months ago (2014-01-09 15:49:49 UTC) #17
*** Submitted as https://code.google.com/p/go/source/detail?r=99a1e180eda3 ***

os, os/exec, os/user: add support for GOOS=solaris

R=golang-codereviews, dave, minux.ma, gobot, jsing
CC=golang-codereviews
https://codereview.appspot.com/36020043

Committer: Joel Sing <jsing@google.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5