Code review - Issue 36020043: code review 36020043: os, os/exec, os/user: add support for GOOS=solarishttps://codereview.appspot.com/2014-01-09T15:49:49+00:00rietveld
Message from unknown
2013-12-02T16:00:19+00:00aramurn:md5:70d2b0b12c09aa7db540ac54a16b1031
Message from unknown
2013-12-02T16:00:24+00:00aramurn:md5:7d44145d8ee63d23ae1a0d12120cd44e
Message from unknown
2013-12-02T16:39:13+00:00aramurn:md5:ce4d48c8f71f69cde60e86d352927e07
Message from unknown
2013-12-02T19:46:59+00:00aramurn:md5:3d6984a076759472677092f29b1602e7
Message from unknown
2013-12-02T19:53:42+00:00aramurn:md5:553722b2e987e447bac8651682f6920a
Message from unknown
2013-12-06T16:31:50+00:00aramurn:md5:5e416b6028521396d783d7942f37ac70
Message from unknown
2013-12-07T14:34:04+00:00aramurn:md5:7ee862d75ad01721ad5ef9595e7d67c2
Message from unknown
2013-12-07T14:35:24+00:00aramurn:md5:f4e29d4aea84b89692186a85c7c5e67b
Message from unknown
2013-12-10T20:36:27+00:00aramurn:md5:3dc7d9c1ca7cdd4f86d054d28c2a60d2
Message from unknown
2013-12-10T20:40:30+00:00aramurn:md5:61cac49979938abc42342350dae6ac62
Message from aram@mgk.ro
2013-12-10T20:40:34+00:00aramurn:md5:dabd45a529857d6199dd52cfa8b414cc
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go
Message from dave@cheney.net
2013-12-10T23:45:17+00:00dfcurn:md5:704c9c2dffa10be408e1f0c82fc2e55b
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go#newcode7
src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong
It's not wrong any more :)
Message from unknown
2013-12-11T21:21:14+00:00aramurn:md5:fc926b0f6f43154282b93e0f7ad7ad75
Message from aram@mgk.ro
2013-12-11T21:27:14+00:00aramurn:md5:36d00a9796b6a4a25929cb9ba360de5c
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):
https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go#newcode7
src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong
On 2013/12/10 23:45:17, dfc wrote:
> It's not wrong any more :)
Done.
Message from unknown
2013-12-12T15:04:58+00:00aramurn:md5:2fcc364cbd77b8aed3e4081f280b3ccc
Message from minux.ma@gmail.com
2013-12-13T07:08:02+00:00minux1urn:md5:37ef59997449ef2d2ef34af70e425d94
LGTM.
Message from gobot@golang.org
2013-12-20T16:26:20+00:00goboturn:md5:916ebd63ef8044b79548a3ba3d45a0b5
Replacing golang-dev with golang-codereviews.
Message from unknown
2013-12-21T21:26:32+00:00aramurn:md5:29a06da3efae29f66f83e77f3e3d49ca
Message from unknown
2013-12-21T21:31:19+00:00aramurn:md5:5cb6bff34ca5b1fba10731a30d39e644
Message from unknown
2013-12-21T21:45:44+00:00aramurn:md5:c0a060db96576aab0007b91afc24ed18
Message from unknown
2013-12-21T21:48:51+00:00aramurn:md5:3310b710fcd77f73071c5fc7da709bc0
Message from aram@mgk.ro
2013-12-21T21:48:58+00:00aramurn:md5:61e9bf53727473fa636a6671d2a01012
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com),
Please take another look.
Message from unknown
2013-12-29T17:43:24+00:00aramurn:md5:d3a5726801918bd6e5af057a121f16aa
Message from unknown
2013-12-29T17:45:11+00:00aramurn:md5:9b495ad884a069508b6711e1008a2d4d
Message from aram@mgk.ro
2013-12-29T17:45:19+00:00aramurn:md5:ebd1862926f8704532153e25972567c6
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com),
Please take another look.
Message from gobot@golang.org
2014-01-07T23:20:11+00:00goboturn:md5:a9a1a68194ab800546854634c1ed7249
R=jsing@google.com (assigned by aram@mgk.ro)
Message from jsing@google.com
2014-01-08T10:38:34+00:00jsingurn:md5:68650dfd5157e6bff9ef8a5376278599
LGTM
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1
src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights reserved.
Copyright years are not updated - please revert this, given that the file is predominantly a copy.
Message from dave@cheney.net
2014-01-08T11:07:09+00:00dfcurn:md5:b92fc8dea5215a88bcd26dc9188f8592
> On 8 Jan 2014, at 21:38, jsing@google.com wrote:
>
> LGTM
>
>
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
> File src/pkg/os/stat_solaris.go (right):
>
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1
> src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All
> rights reserved.
> Copyright years are not updated - please revert this, given that the
> file is predominantly a copy.
Id like to disagree, this is a new file, even if 99% of it is a copy from someplace else.
>
> https://codereview.appspot.com/36020043/
Message from jsing@google.com
2014-01-08T11:30:13+00:00jsingurn:md5:8e778cf4f24f88d6b82fc4508e0c9014
On 2014/01/08 11:07:09, dfc wrote:
>
> > On 8 Jan 2014, at 21:38, mailto:jsing@google.com wrote:
> >
> > LGTM
> >
> >
> >
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
> > File src/pkg/os/stat_solaris.go (right):
> >
> >
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1
> > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All
> > rights reserved.
> > Copyright years are not updated - please revert this, given that the
> > file is predominantly a copy.
>
> Id like to disagree, this is a new file, even if 99% of it is a copy from
> someplace else.
It may be a new file, however it is a derivative work and as I understand it, the original copyright year applies.
Message from dave@cheney.net
2014-01-08T11:33:04+00:00dfcurn:md5:87d1d1589418d7049e5146e287e641af
Sure. But I can cite many examples in the current code base that can support *both* of our positions.
> On 8 Jan 2014, at 22:30, jsing@google.com wrote:
>
>> On 2014/01/08 11:07:09, dfc wrote:
>>
>> > On 8 Jan 2014, at 21:38, mailto:jsing@google.com wrote:
>> >
>> > LGTM
>> >
>> >
>> >
>
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
>> > File src/pkg/os/stat_solaris.go (right):
>> >
>> >
>
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1
>> > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All
>> > rights reserved.
>> > Copyright years are not updated - please revert this, given that the
>> > file is predominantly a copy.
>
>> Id like to disagree, this is a new file, even if 99% of it is a copy
> from
>> someplace else.
>
> It may be a new file, however it is a derivative work and as I
> understand it, the original copyright year applies.
>
> https://codereview.appspot.com/36020043/
>
> --
> You received this message because you are subscribed to the Google Groups "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Message from unknown
2014-01-09T14:55:50+00:00aramurn:md5:8791acc6dca6558da1a69ee105eaf3d2
Message from aram@mgk.ro
2014-01-09T15:09:16+00:00aramurn:md5:39c084632028ec585c34d12fd0a4ee7d
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go#newcode1
src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights reserved.
On 2014/01/08 10:38:35, jsing wrote:
> Copyright years are not updated - please revert this, given that the file is
> predominantly a copy.
Done.
Message from aram@mgk.ro
2014-01-09T15:09:17+00:00aramurn:md5:9584854443d1f35a672aa1f4deb73ca4
Message from unknown
2014-01-09T15:10:47+00:00aramurn:md5:0b42ae558f4972b4112e2b9ee09cd73a
Message from aram@mgk.ro
2014-01-09T15:11:02+00:00aramurn:md5:c02c4cdd349e1534f4f635a0f2737784
Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com, gobot@golang.org, jsing@google.com (cc: golang-codereviews@googlegroups.com),
Please take another look.
Message from unknown
2014-01-09T15:41:56+00:00aramurn:md5:653139023942da03413c6496679095f8
Message from jsing@google.com
2014-01-09T15:48:13+00:00jsingurn:md5:5abfd454960e6bbaba2526f1778fd8f0
LGTM
Message from jsing@google.com
2014-01-09T15:49:49+00:00jsingurn:md5:37c6475c815f8c5db7c6cf605554e570
*** Submitted as https://code.google.com/p/go/source/detail?r=99a1e180eda3 ***
os, os/exec, os/user: add support for GOOS=solaris
R=golang-codereviews, dave, minux.ma, gobot, jsing
CC=golang-codereviews
https://codereview.appspot.com/36020043
Committer: Joel Sing <jsing@google.com>